components/autofill/content/common/autofill_types_struct_traits.cc - Issue 2640783002: [Password Generation] Send id attribute to server for HTML based form classifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_types_struct_traits.cc

Issue 2640783002: [Password Generation] Send id attribute to server for HTML based form classifier (Closed)

Patch Set: Changes addressed to reviewer comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/common/autofill_types_struct_traits.cc

diff --git a/components/autofill/content/common/autofill_types_struct_traits.cc b/components/autofill/content/common/autofill_types_struct_traits.cc

index b27f8a563a5a4b019d13bd7cd3d71332c5312383..d3214a14b8c1d782aa25dc909a5de9bd1a106ad6 100644

--- a/components/autofill/content/common/autofill_types_struct_traits.cc

+++ b/components/autofill/content/common/autofill_types_struct_traits.cc

@@ -295,6 +295,8 @@ bool StructTraits<mojom::FormFieldDataDataView, FormFieldData>::Read(

return false;

if (!data.ReadName(&out->name))

return false;

+ if (!data.ReadId(&out->id))

+ return false;

if (!data.ReadValue(&out->value))

return false;