components/autofill/content/common/autofill_types_struct_traits_unittest.cc - Issue 2640783002: [Password Generation] Send id attribute to server for HTML based form classifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_types_struct_traits_unittest.cc

Issue 2640783002: [Password Generation] Send id attribute to server for HTML based form classifier (Closed)

Patch Set: Changes addressed to reviewer comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/common/autofill_types_struct_traits.cc ('k') | components/autofill/content/renderer/form_autofill_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_types_struct_traits_unittest.cc

diff --git a/components/autofill/content/common/autofill_types_struct_traits_unittest.cc b/components/autofill/content/common/autofill_types_struct_traits_unittest.cc

index 2da13f212b16d241f16d29f27ea944301a688279..1ac7a7495be331beb355ff0ebf3762755f3feabc 100644

--- a/components/autofill/content/common/autofill_types_struct_traits_unittest.cc

+++ b/components/autofill/content/common/autofill_types_struct_traits_unittest.cc

@@ -327,6 +327,7 @@ TEST_F(AutofillTypeTraitsTestImpl, PassFormFieldData) {

test::CreateTestSelectField("TestLabel", "TestName", "TestValue", kOptions,

kOptions, 4, &input);

// Set other attributes to check if they are passed correctly.

+ input.id = base::ASCIIToUTF16("id");

input.autocomplete_attribute = "on";

input.placeholder = base::ASCIIToUTF16("placeholder");

input.css_classes = base::ASCIIToUTF16("class1");