components/autofill/content/common/autofill_types_struct_traits.h - Issue 2640783002: [Password Generation] Send id attribute to server for HTML based form classifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_types_struct_traits.h

Issue 2640783002: [Password Generation] Send id attribute to server for HTML based form classifier (Closed)

Patch Set: Changes addressed to reviewer comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/common/autofill_types_struct_traits.h

diff --git a/components/autofill/content/common/autofill_types_struct_traits.h b/components/autofill/content/common/autofill_types_struct_traits.h

index 934f8801855eaba0a26b73d8c605cb8bd649beb2..a9785e39848218772f7733c2a40170f09d3ced67 100644

--- a/components/autofill/content/common/autofill_types_struct_traits.h

+++ b/components/autofill/content/common/autofill_types_struct_traits.h

@@ -96,6 +96,10 @@ struct StructTraits<autofill::mojom::FormFieldDataDataView,

return r.name;

}

+ static const base::string16& id(const autofill::FormFieldData& r) {

+ return r.id;

+ }

static const base::string16& value(const autofill::FormFieldData& r) {

return r.value;

}