📰 Use first seen position in suggestion UMA

[NTP Client] Use first seen position in suggestion UMA

Updates the description and calculation to be more consistent
with what we want to track and more accurate across the different
modifications the suggestion surface can go through.
This means that instead of tracking the position at the moment the
item is loaded, we track the position when it is bound to the view
and the user has a chance to see it.

BUG=675623
Review-Url: https://codereview.chromium.org/2640443003
Cr-Commit-Position: refs/heads/master@{#444693}
Committed: https://chromium.googlesource.com/chromium/src/+/ecb7bd1cd2294ead17cb71265c98a9574dd5f342

[dgn, 2017-01-17 17:20:27]

dgn@chromium.org changed reviewers:
+ bauerb@chromium.org, treib@chromium.org, tschumann@chromium.org

[dgn, 2017-01-17 17:20:28]

PTAL. The previous patch tried to keep a behaviour in line with the previous
description while taking into account the fact that we now support fetch more,
while this one tweaks a the way we report position.

The test hopefully illustrates the difference.

[Marc Treib, 2017-01-17 17:45:04]

Some desription nits, otherwise lgtm

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:38958: +    suggestions from the list of
requested more that got inserted in the middle
s/of/or/

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:38972: +    from the list of requested
more that got inserted in the middle of the feed.
s/of/or/

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:39018: +    Android: The position of the
snippets card on the NTP, that is clicked
s/snippets/suggestion/

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:39019: +    through to the host website
of the content. We track the order in which the
We track the position the card had in the list when it was first seen by the
user. ...

(consistent with the other descriptions)

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:39051: +    We track the order in which
the snippets are added to the visible surface.
Also here, copy&paste the text from the first two descriptions.

Are these all the histograms that have the position-explanation text?

[dgn, 2017-01-18 11:09:04]

Patchset #3 (id:40001) has been deleted

[dgn, 2017-01-18 14:04:23]

dgn@chromium.org changed reviewers:
+ rkaplow@chromium.org

[dgn, 2017-01-18 14:04:24]

rkaplow@: I updated some histograms descriptions. PTAL

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:38958: +    suggestions from the list of
requested more that got inserted in the middle
On 2017/01/17 17:45:04, Marc Treib wrote:
> s/of/or/

Done.

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:38972: +    from the list of requested
more that got inserted in the middle of the feed.
On 2017/01/17 17:45:04, Marc Treib wrote:
> s/of/or/

Done.

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:39018: +    Android: The position of the
snippets card on the NTP, that is clicked
On 2017/01/17 17:45:04, Marc Treib wrote:
> s/snippets/suggestion/

Done.

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:39019: +    through to the host website
of the content. We track the order in which the
On 2017/01/17 17:45:04, Marc Treib wrote:
> We track the position the card had in the list when it was first seen by the
> user. ...
> 
> (consistent with the other descriptions)

Done.

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:39051: +    We track the order in which
the snippets are added to the visible surface.
On 2017/01/17 17:45:04, Marc Treib wrote:
> Also here, copy&paste the text from the first two descriptions.

Done.
> Are these all the histograms that have the position-explanation text?

Found a couple more, for visited metrics. I did not update the descriptions
associated to the deprecated metrics.

[dgn, 2017-01-18 14:04:37]

The CQ bit was checked by dgn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 14:04:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marc Treib, 2017-01-18 14:24:17]

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2640443003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:39051: +    We track the order in which
the snippets are added to the visible surface.
On 2017/01/18 14:04:24, dgn wrote:
> On 2017/01/17 17:45:04, Marc Treib wrote:
> > Also here, copy&paste the text from the first two descriptions.
> 
> Done.
> > Are these all the histograms that have the position-explanation text?
> 
> Found a couple more, for visited metrics. I did not update the descriptions
> associated to the deprecated metrics.

SGTM, thanks!

[commit-bot: I haz the power, 2017-01-18 15:14:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 15:14:38]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-01-18 18:49:44]

lgtm

[dgn, 2017-01-19 10:03:50]

The CQ bit was checked by dgn@chromium.org

[dgn, 2017-01-19 10:03:50]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/2640443003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-19 10:04:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 10:08:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484820230108330,
"parent_rev": "4972918f66895adb6391464ebf9dca41bfccf9f8", "commit_rev":
"ecb7bd1cd2294ead17cb71265c98a9574dd5f342"}

[commit-bot: I haz the power, 2017-01-19 10:08:51]

Description was changed from

==========
[NTP Client] Use first seen position in suggestion UMA

Updates the description and calculation to be more consistent
with what we want to track and more accurate across the different
modifications the suggestion surface can go through.
This means that instead of tracking the position at the moment the
item is loaded, we track the position when it is bound to the view
and the user has a chance to see it.

BUG=675623
==========

to

==========
[NTP Client] Use first seen position in suggestion UMA

Updates the description and calculation to be more consistent
with what we want to track and more accurate across the different
modifications the suggestion surface can go through.
This means that instead of tracking the position at the moment the
item is loaded, we track the position when it is bound to the view
and the user has a chance to see it.

BUG=675623

Review-Url: https://codereview.chromium.org/2640443003
Cr-Commit-Position: refs/heads/master@{#444693}
Committed:
https://chromium.googlesource.com/chromium/src/+/ecb7bd1cd2294ead17cb71265c98...
==========

[commit-bot: I haz the power, 2017-01-19 10:08:52]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ecb7bd1cd2294ead17cb71265c98...