chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRanker.java - Issue 2640443003: 📰 Use first seen position in suggestion UMA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRanker.java

Issue 2640443003: 📰 Use first seen position in suggestion UMA (Closed)

Patch Set: rebase Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/SectionListTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRanker.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRanker.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRanker.java

index 49b546e42adad9266e4da3833166560b05aedcce..2652d514a0397f9b5f2bcf03741da217dcebc1a2 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRanker.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsRanker.java

@@ -37,6 +37,8 @@ public void rankActionItem(ActionItem actionItem, SuggestionsSection section) {

* @see SnippetArticle#getGlobalRank()

public void rankSuggestion(SnippetArticle suggestion) {

+ if (suggestion.getPerSectionRank() != -1) return; // Suggestion was already ranked.

int globalRank = mTotalAddedSuggestions++;

int perSectionRank = mSuggestionsAddedPerSection.get(suggestion.mCategory);

mSuggestionsAddedPerSection.put(suggestion.mCategory, perSectionRank + 1);