[ios] Decouples ToolsMenuViewToolsCell from ToolsMenuVC

[ios] Decouples ToolsMenuViewToolsCell from ToolsMenuVC

Creates .h and .mm files for ToolsMenuViewToolsCell, and deletes ToolsMenuButton entirely since it had no implementation. 

BUG=682880
Review-Url: https://codereview.chromium.org/2640423003
Cr-Commit-Position: refs/heads/master@{#445218}
Committed: https://chromium.googlesource.com/chromium/src/+/1f539fb3b13ffc0e25538dbe9e6886c314a7f541

[sczs, 2017-01-19 23:47:02]

Description was changed from

==========
[ios] Decouples ToolsMenuViewToolsCell from ToolsMenuVC

BUG=
==========

to

==========
[ios] Decouples ToolsMenuViewToolsCell from ToolsMenuVC

Creates .h and .mm files for ToolsMenuViewToolsCell, and deletes ToolsMenuButton
entirely since it had no implementation. 

BUG=682880
==========

[sczs, 2017-01-19 23:47:02]

sczs@chromium.org changed reviewers:
+ edchin@chromium.org, lpromero@chromium.org, marq@chromium.org

[sczs, 2017-01-19 23:47:49]

PTAL, is a simple CL that creates files for a Cell Class

[edchin, 2017-01-20 00:05:46]

lgtm. (not an owner).

[sczs, 2017-01-20 00:06:54]

sczs@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sczs, 2017-01-20 01:06:29]

+rohitrao

[lpromero, 2017-01-20 09:05:16]

lgtm

https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools...
File ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h (right):

https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools...
ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h:1: // Copyright
2016 The Chromium Authors. All rights reserved.
2017. Idem second file. Use ./tools/boilerplate.py to create new files.

https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools...
ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h:10: @interface
ToolsMenuViewToolsCell : UICollectionViewCell
Add a class comment.

https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools...
File ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm (right):

https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools...
ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm:174:
@"H:|-(offset)-[share]-(space)-[star]-(space)-[reload]",
Please paste with ⇧⌥⌘V to keep the original indent.

[marq (ping after 24h), 2017-01-20 10:23:16]

Overall LGTM as a straightforward refactor; I'm fine with not cleaning up the
implementation code, but the header needs more comments.

https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools...
File ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h (right):

https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools...
ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h:11:
@property(nonatomic, retain) UIButton* reloadButton;
Each property needs a comment. Is it expected that every instance of the cell
class will have more than one of these as non-nil properties?

[sczs, 2017-01-20 23:03:15]

https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools...
File ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h (right):

https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools...
ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h:1: // Copyright
2016 The Chromium Authors. All rights reserved.
On 2017/01/20 09:05:16, lpromero wrote:
> 2017. Idem second file. Use ./tools/boilerplate.py to create new files.

Done.

https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools...
ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h:10: @interface
ToolsMenuViewToolsCell : UICollectionViewCell
On 2017/01/20 09:05:16, lpromero wrote:
> Add a class comment.

Done.

https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools...
ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h:11:
@property(nonatomic, retain) UIButton* reloadButton;
On 2017/01/20 10:23:16, marq wrote:
> Each property needs a comment. Is it expected that every instance of the cell
> class will have more than one of these as non-nil properties?

Are you asking because of nullability annotations? I could add those too, not
sure if we prefer to use macros or annotate each of them (These should never be
null).
I'm also using strong instead of retain to make it more "ARCy".

https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools...
File ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm (right):

https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools...
ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm:174:
@"H:|-(offset)-[share]-(space)-[star]-(space)-[reload]",
On 2017/01/20 09:05:16, lpromero wrote:
> Please paste with ⇧⌥⌘V to keep the original indent.
Done.
Thanks for the tip! Not usually a problem, but clang-format being off messed it
up.

[sczs, 2017-01-20 23:03:54]

The CQ bit was checked by sczs@chromium.org

[sczs, 2017-01-20 23:03:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
lpromero@chromium.org, edchin@chromium.org, marq@chromium.org
Link to the patchset: https://codereview.chromium.org/2640423003/#ps20001
(title: "CL Feedback")

[commit-bot: I haz the power, 2017-01-20 23:04:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 00:06:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484953434881800,
"parent_rev": "c12ff60701ca387b992c0d8d4127410aa108b15e", "commit_rev":
"1f539fb3b13ffc0e25538dbe9e6886c314a7f541"}

[commit-bot: I haz the power, 2017-01-21 00:07:24]

Description was changed from

==========
[ios] Decouples ToolsMenuViewToolsCell from ToolsMenuVC

Creates .h and .mm files for ToolsMenuViewToolsCell, and deletes ToolsMenuButton
entirely since it had no implementation. 

BUG=682880
==========

to

==========
[ios] Decouples ToolsMenuViewToolsCell from ToolsMenuVC

Creates .h and .mm files for ToolsMenuViewToolsCell, and deletes ToolsMenuButton
entirely since it had no implementation. 

BUG=682880

Review-Url: https://codereview.chromium.org/2640423003
Cr-Commit-Position: refs/heads/master@{#445218}
Committed:
https://chromium.googlesource.com/chromium/src/+/1f539fb3b13ffc0e25538dbe9e68...
==========

[commit-bot: I haz the power, 2017-01-21 00:07:25]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f539fb3b13ffc0e25538dbe9e68...