Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2640423003: [ios] Decouples ToolsMenuViewToolsCell from ToolsMenuVC (Closed)

Created:
3 years, 11 months ago by sczs
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Decouples ToolsMenuViewToolsCell from ToolsMenuVC Creates .h and .mm files for ToolsMenuViewToolsCell, and deletes ToolsMenuButton entirely since it had no implementation. BUG=682880 Review-Url: https://codereview.chromium.org/2640423003 Cr-Commit-Position: refs/heads/master@{#445218} Committed: https://chromium.googlesource.com/chromium/src/+/1f539fb3b13ffc0e25538dbe9e6886c314a7f541

Patch Set 1 #

Total comments: 8

Patch Set 2 : CL Feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+242 lines, -204 lines) Patch
M ios/chrome/browser/ui/tools_menu/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm View 3 chunks +1 line, -204 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm View 1 1 chunk +205 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
sczs
PTAL, is a simple CL that creates files for a Cell Class
3 years, 11 months ago (2017-01-19 23:47:49 UTC) #3
edchin
lgtm. (not an owner).
3 years, 11 months ago (2017-01-20 00:05:46 UTC) #4
sczs
+rohitrao
3 years, 11 months ago (2017-01-20 01:06:29 UTC) #6
lpromero
lgtm https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h File ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h (right): https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h#newcode1 ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h:1: // Copyright 2016 The Chromium Authors. All rights ...
3 years, 11 months ago (2017-01-20 09:05:16 UTC) #7
marq (ping after 24h)
Overall LGTM as a straightforward refactor; I'm fine with not cleaning up the implementation code, ...
3 years, 11 months ago (2017-01-20 10:23:16 UTC) #8
sczs
https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h File ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h (right): https://codereview.chromium.org/2640423003/diff/1/ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h#newcode1 ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h:1: // Copyright 2016 The Chromium Authors. All rights reserved. ...
3 years, 11 months ago (2017-01-20 23:03:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640423003/20001
3 years, 11 months ago (2017-01-20 23:04:21 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 00:07:25 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1f539fb3b13ffc0e25538dbe9e68...

Powered by Google App Engine
This is Rietveld 408576698