ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h - Issue 2640423003: [ios] Decouples ToolsMenuViewToolsCell from ToolsMenuVC

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h

Issue 2640423003: [ios] Decouples ToolsMenuViewToolsCell from ToolsMenuVC (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm ('k') | ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm » ('j') | ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.
	lpromero 2017/01/20 09:05:16 2017. Idem second file. Use ./tools/boilerplate.py 2017. Idem second file. Use ./tools/boilerplate.py to create new files. sczs 2017/01/20 23:03:15 Done. Show quoted text On 2017/01/20 09:05:16, lpromero wrote: > 2017. Idem second file. Use ./tools/boilerplate.py to create new files. Done.
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IOS_CHROME_BROWSER_UI_TOOLS_MENU_TOOLS_MENU_VIEW_TOOLS_CELL_H_

	6 #define IOS_CHROME_BROWSER_UI_TOOLS_MENU_TOOLS_MENU_VIEW_TOOLS_CELL_H_

	7

	8 #import <UIKit/UIKit.h>

	9

	10 @interface ToolsMenuViewToolsCell : UICollectionViewCell
	lpromero 2017/01/20 09:05:16 Add a class comment. Add a class comment. sczs 2017/01/20 23:03:15 Done. Show quoted text On 2017/01/20 09:05:16, lpromero wrote: > Add a class comment. Done.
	11 @property(nonatomic, retain) UIButton* reloadButton;
	marq (ping after 24h) 2017/01/20 10:23:16 Each property needs a comment. Is it expected that Each property needs a comment. Is it expected that every instance of the cell class will have more than one of these as non-nil properties? sczs 2017/01/20 23:03:15 Are you asking because of nullability annotations? Show quoted text On 2017/01/20 10:23:16, marq wrote: > Each property needs a comment. Is it expected that every instance of the cell > class will have more than one of these as non-nil properties? Are you asking because of nullability annotations? I could add those too, not sure if we prefer to use macros or annotate each of them (These should never be null). I'm also using strong instead of retain to make it more "ARCy".
	12 @property(nonatomic, retain) UIButton* shareButton;

	13 @property(nonatomic, retain) UIButton* starButton;

	14 @property(nonatomic, retain) UIButton* starredButton;

	15 @property(nonatomic, retain) UIButton* stopButton;

	16 @property(nonatomic, retain) UIButton* toolsButton;

	17

	18 // All buttons in the cell added in display order.

	19 - (NSArray*)allButtons;

	20 @end

	21

	22 #endif // IOS_CHROME_BROWSER_UI_TOOLS_MENU_TOOLS_MENU_VIEW_TOOLS_CELL_H_

OLD	NEW