Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2640403004: [wasm] Instance exports object should be iterable (Closed)

Created:
3 years, 11 months ago by gdeepti
Modified:
3 years, 11 months ago
Reviewers:
titzer, Derek Schuff
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Instance exports object should be iterable BUG=v8:5863 R=titzer@chromium.org, dschuff@chromium.org Review-Url: https://codereview.chromium.org/2640403004 Cr-Commit-Position: refs/heads/master@{#42578} Committed: https://chromium.googlesource.com/v8/v8/+/2ca39001c8c134fce0bfc6f9f73044ff82671156

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/wasm/wasm-module.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/wasm/instantiate-module-basic.js View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
gdeepti
3 years, 11 months ago (2017-01-20 01:45:58 UTC) #3
titzer
lgtm with comment https://codereview.chromium.org/2640403004/diff/1/test/mjsunit/regress/wasm/regression-5863.js File test/mjsunit/regress/wasm/regression-5863.js (right): https://codereview.chromium.org/2640403004/diff/1/test/mjsunit/regress/wasm/regression-5863.js#newcode1 test/mjsunit/regress/wasm/regression-5863.js:1: // Copyright 2017 the V8 project ...
3 years, 11 months ago (2017-01-20 09:12:02 UTC) #6
gdeepti
https://codereview.chromium.org/2640403004/diff/1/test/mjsunit/regress/wasm/regression-5863.js File test/mjsunit/regress/wasm/regression-5863.js (right): https://codereview.chromium.org/2640403004/diff/1/test/mjsunit/regress/wasm/regression-5863.js#newcode1 test/mjsunit/regress/wasm/regression-5863.js:1: // Copyright 2017 the V8 project authors. All rights ...
3 years, 11 months ago (2017-01-20 18:12:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640403004/20001
3 years, 11 months ago (2017-01-20 18:19:33 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 19:35:23 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/2ca39001c8c134fce0bfc6f9f73044ff826...

Powered by Google App Engine
This is Rietveld 408576698