src/wasm/wasm-module.cc - Issue 2640403004: [wasm] Instance exports object should be iterable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-module.cc

Issue 2640403004: [wasm] Instance exports object should be iterable (Closed)

Patch Set: Review Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/wasm-module.cc

diff --git a/src/wasm/wasm-module.cc b/src/wasm/wasm-module.cc

index b10570fe2c2c33906108f8e9a0656301044cc8ea..c38ce3a4f5323189bd721021411985c084c66e7b 100644

--- a/src/wasm/wasm-module.cc

+++ b/src/wasm/wasm-module.cc

@@ -1884,6 +1884,7 @@ class WasmInstanceBuilder {

PropertyDescriptor desc;

desc.set_writable(false);

+ desc.set_enumerable(true);

// Count up export indexes.

int export_index = 0;

« no previous file with comments | « no previous file | test/mjsunit/wasm/instantiate-module-basic.js » ('j') | no next file with comments »