Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2640403003: Fix UI glitches on Performance and Memory panels (Closed)

Created:
3 years, 11 months ago by alph
Modified:
3 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix UI glitches on Performance and Memory panels Network pane font was inconsistent. Target select combobox on Memory panel had no padding. Default tree view height was too small. BUG=682892 Review-Url: https://codereview.chromium.org/2640403003 Cr-Original-Commit-Position: refs/heads/master@{#444959} Committed: https://chromium.googlesource.com/chromium/src/+/5ffeda5222ba52d797c90dd247be0113c0ced577 Review-Url: https://codereview.chromium.org/2640403003 Cr-Commit-Position: refs/heads/master@{#445249} Committed: https://chromium.googlesource.com/chromium/src/+/2d74d5b6592b0cef8b085bfa07711473dfae707f

Patch Set 1 #

Patch Set 2 : fix tooltip text #

Patch Set 3 : fix flamechart panning bug #

Messages

Total messages: 20 (12 generated)
alph
3 years, 11 months ago (2017-01-20 00:16:10 UTC) #2
pfeldman
lgtm
3 years, 11 months ago (2017-01-20 00:21:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640403003/1
3 years, 11 months ago (2017-01-20 00:22:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640403003/20001
3 years, 11 months ago (2017-01-20 00:54:34 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/5ffeda5222ba52d797c90dd247be0113c0ced577
3 years, 11 months ago (2017-01-20 02:43:48 UTC) #12
alph
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2646193003/ by alph@chromium.org. ...
3 years, 11 months ago (2017-01-20 22:23:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640403003/40001
3 years, 11 months ago (2017-01-21 00:17:26 UTC) #17
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 02:05:46 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2d74d5b6592b0cef8b085bfa0771...

Powered by Google App Engine
This is Rietveld 408576698