Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js

Issue 2640403003: Fix UI glitches on Performance and Memory panels (Closed)
Patch Set: fix flamechart panning bug Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
diff --git a/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js b/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
index 179e529279978c34d41df04978233c7bc46b73f9..2aa66918cc493bec2871d307e153cec851908f85 100644
--- a/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
+++ b/third_party/WebKit/Source/devtools/front_end/perf_ui/FlameChart.js
@@ -697,7 +697,6 @@ PerfUI.FlameChart = class extends PerfUI.ChartViewport {
context.fillStyle = this._dataProvider.textColor(entryIndex);
context.fillText(text, barX + textPadding, barY + textBaseHeight);
}
-
context.restore();
this._drawGroupHeaders(width, height);
@@ -731,6 +730,8 @@ PerfUI.FlameChart = class extends PerfUI.ChartViewport {
context.save();
context.scale(ratio, ratio);
context.translate(0, -top);
+ var defaultFont = '11px ' + Host.fontFamily();
+ context.font = defaultFont;
context.fillStyle = UI.themeSupport.patchColor('#fff', colorUsage.Background);
forEachGroup.call(this, (offset, index, group) => {
@@ -876,7 +877,7 @@ PerfUI.FlameChart = class extends PerfUI.ChartViewport {
var timeWindowRight = this._timeWindowRight;
var timeWindowLeft = this._timeWindowLeft - this._paddingLeft / this._timeToPixel;
var context = /** @type {!CanvasRenderingContext2D} */ (this._canvas.getContext('2d'));
- var barHeight = this._barHeight - 2;
+ var barHeight = this._barHeight - 1;
var entryStartTimes = this._rawTimelineData.entryStartTimes;
var entryTotalTimes = this._rawTimelineData.entryTotalTimes;
@@ -903,9 +904,9 @@ PerfUI.FlameChart = class extends PerfUI.ChartViewport {
const barWidth = endBarX - barX;
context.beginPath();
context.fillStyle = color;
- context.fillRect(barX, y, barWidth, barHeight - 1);
+ context.fillRect(barX, y, barWidth, barHeight);
this._dataProvider.decorateEntry(
- entryIndex, context, '', barX, y, barWidth, barHeight, unclippedBarX, this._timeToPixel);
+ entryIndex, context, '', barX, y, barWidth, this._barHeight, unclippedBarX, this._timeToPixel);
continue;
}
range.append(new Common.Segment(barX, endBarX, color));
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/profiler/profilesPanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698