Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2640303002: Add an api to disable recording task delay histogrames (Closed)

Created:
3 years, 11 months ago by alex clarke (OOO till 29th)
Modified:
3 years, 11 months ago
Reviewers:
Sami
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an api to disable recording task delay histograms There's a small overhead for recording task delay histograms and it's not needed on every thread. Originally part of https://codereview.chromium.org/2546423002/ BUG=578176 Review-Url: https://codereview.chromium.org/2640303002 Cr-Commit-Position: refs/heads/master@{#445029} Committed: https://chromium.googlesource.com/chromium/src/+/1b5ef968a2604c1775483e86a5928c95d8688e68

Patch Set 1 #

Patch Set 2 : Fix bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc View 1 3 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
alex clarke (OOO till 29th)
PTAL
3 years, 11 months ago (2017-01-19 15:33:07 UTC) #4
Sami
lgtm
3 years, 11 months ago (2017-01-19 17:25:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2640303002/20001
3 years, 11 months ago (2017-01-20 08:51:14 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 10:18:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1b5ef968a2604c1775483e86a592...

Powered by Google App Engine
This is Rietveld 408576698