Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc

Issue 2640303002: Add an api to disable recording task delay histogrames (Closed)
Patch Set: Fix bad merge Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/scheduler/base/task_queue_manager.h" 5 #include "platform/scheduler/base/task_queue_manager.h"
6 6
7 #include <queue> 7 #include <queue>
8 #include <set> 8 #include <set>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 52
53 TaskQueueManager::TaskQueueManager( 53 TaskQueueManager::TaskQueueManager(
54 scoped_refptr<TaskQueueManagerDelegate> delegate, 54 scoped_refptr<TaskQueueManagerDelegate> delegate,
55 const char* tracing_category, 55 const char* tracing_category,
56 const char* disabled_by_default_tracing_category, 56 const char* disabled_by_default_tracing_category,
57 const char* disabled_by_default_verbose_tracing_category) 57 const char* disabled_by_default_verbose_tracing_category)
58 : real_time_domain_(new RealTimeDomain(tracing_category)), 58 : real_time_domain_(new RealTimeDomain(tracing_category)),
59 delegate_(delegate), 59 delegate_(delegate),
60 task_was_run_on_quiescence_monitored_queue_(false), 60 task_was_run_on_quiescence_monitored_queue_(false),
61 other_thread_pending_wakeup_(false), 61 other_thread_pending_wakeup_(false),
62 record_task_delay_histograms_(true),
62 work_batch_size_(1), 63 work_batch_size_(1),
63 task_count_(0), 64 task_count_(0),
64 tracing_category_(tracing_category), 65 tracing_category_(tracing_category),
65 disabled_by_default_tracing_category_( 66 disabled_by_default_tracing_category_(
66 disabled_by_default_tracing_category), 67 disabled_by_default_tracing_category),
67 disabled_by_default_verbose_tracing_category_( 68 disabled_by_default_verbose_tracing_category_(
68 disabled_by_default_verbose_tracing_category), 69 disabled_by_default_verbose_tracing_category),
69 currently_executing_task_queue_(nullptr), 70 currently_executing_task_queue_(nullptr),
70 observer_(nullptr), 71 observer_(nullptr),
71 deletion_sentinel_(new DeletionSentinel()), 72 deletion_sentinel_(new DeletionSentinel()),
(...skipping 268 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 // TODO(skyostil): Figure out a way to not forget which task queue the 341 // TODO(skyostil): Figure out a way to not forget which task queue the
341 // task is associated with. See http://crbug.com/522843. 342 // task is associated with. See http://crbug.com/522843.
342 // TODO(tzik): Remove base::UnsafeConvertOnceClosureToRepeating once 343 // TODO(tzik): Remove base::UnsafeConvertOnceClosureToRepeating once
343 // TaskRunners have migrated to OnceClosure. 344 // TaskRunners have migrated to OnceClosure.
344 delegate_->PostNonNestableTask( 345 delegate_->PostNonNestableTask(
345 pending_task.posted_from, 346 pending_task.posted_from,
346 UnsafeConvertOnceClosureToRepeating(std::move(pending_task.task))); 347 UnsafeConvertOnceClosureToRepeating(std::move(pending_task.task)));
347 return ProcessTaskResult::DEFERRED; 348 return ProcessTaskResult::DEFERRED;
348 } 349 }
349 350
350 MaybeRecordTaskDelayHistograms(pending_task, queue); 351 if (record_task_delay_histograms_)
352 MaybeRecordTaskDelayHistograms(pending_task, queue);
351 353
352 double task_start_time = 0; 354 double task_start_time = 0;
353 TRACE_TASK_EXECUTION("TaskQueueManager::ProcessTaskFromWorkQueue", 355 TRACE_TASK_EXECUTION("TaskQueueManager::ProcessTaskFromWorkQueue",
354 pending_task); 356 pending_task);
355 if (queue->GetShouldNotifyObservers()) { 357 if (queue->GetShouldNotifyObservers()) {
356 for (auto& observer : task_observers_) 358 for (auto& observer : task_observers_)
357 observer.WillProcessTask(pending_task); 359 observer.WillProcessTask(pending_task);
358 queue->NotifyWillProcessTask(pending_task); 360 queue->NotifyWillProcessTask(pending_task);
359 361
360 bool notify_time_observers = 362 bool notify_time_observers =
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 if (observer_) { 518 if (observer_) {
517 observer_->OnTriedToExecuteBlockedTask(*work_queue->task_queue(), 519 observer_->OnTriedToExecuteBlockedTask(*work_queue->task_queue(),
518 *work_queue->GetFrontTask()); 520 *work_queue->GetFrontTask());
519 } 521 }
520 } 522 }
521 523
522 bool TaskQueueManager::HasImmediateWorkForTesting() const { 524 bool TaskQueueManager::HasImmediateWorkForTesting() const {
523 return !selector_.EnabledWorkQueuesEmpty(); 525 return !selector_.EnabledWorkQueuesEmpty();
524 } 526 }
525 527
528 void TaskQueueManager::SetRecordTaskDelayHistograms(
529 bool record_task_delay_histograms) {
530 DCHECK(main_thread_checker_.CalledOnValidThread());
531 record_task_delay_histograms_ = record_task_delay_histograms;
532 }
533
526 void TaskQueueManager::SweepCanceledDelayedTasks() { 534 void TaskQueueManager::SweepCanceledDelayedTasks() {
527 std::map<TimeDomain*, base::TimeTicks> time_domain_now; 535 std::map<TimeDomain*, base::TimeTicks> time_domain_now;
528 for (const scoped_refptr<internal::TaskQueueImpl>& queue : queues_) { 536 for (const scoped_refptr<internal::TaskQueueImpl>& queue : queues_) {
529 TimeDomain* time_domain = queue->GetTimeDomain(); 537 TimeDomain* time_domain = queue->GetTimeDomain();
530 if (time_domain_now.find(time_domain) == time_domain_now.end()) 538 if (time_domain_now.find(time_domain) == time_domain_now.end())
531 time_domain_now.insert(std::make_pair(time_domain, time_domain->Now())); 539 time_domain_now.insert(std::make_pair(time_domain, time_domain->Now()));
532 queue->SweepCanceledDelayedTasks(time_domain_now[time_domain]); 540 queue->SweepCanceledDelayedTasks(time_domain_now[time_domain]);
533 } 541 }
534 } 542 }
535 543
536 } // namespace scheduler 544 } // namespace scheduler
537 } // namespace blink 545 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698