Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: ios/chrome/browser/tabs/tab_model_unittest.mm

Issue 2640093004: WebStateList is an array of web::WebState* wrappers. (Closed)
Patch Set: Fix leaks (caught by unit tests). Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | ios/shared/chrome/browser/tabs/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_model_unittest.mm b/ios/chrome/browser/tabs/tab_model_unittest.mm
index dfb7c664fa0765e6c3ba4fd5579ab33ee0a8d3b1..e298a8cbc12b2166c1519e7c8ddce7883b1bad18 100644
--- a/ios/chrome/browser/tabs/tab_model_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_model_unittest.mm
@@ -838,6 +838,7 @@ TEST_F(TabModelTest, SetParentModel) {
TEST_F(TabModelTest, PersistSelectionChange) {
TestChromeBrowserState::Builder test_cbs_builder;
auto chrome_browser_state = test_cbs_builder.Build();
+ base::mac::ScopedNSAutoreleasePool pool;
NSString* stashPath =
base::SysUTF8ToNSString(chrome_browser_state->GetStatePath().value());
@@ -875,6 +876,7 @@ TEST_F(TabModelTest, PersistSelectionChange) {
browserState:chrome_browser_state.get()]);
EXPECT_EQ(model.get().currentTab, [model tabAtIndex:1]);
[model browserStateDestroyed];
+ model.reset();
// Clean up.
EXPECT_TRUE([[NSFileManager defaultManager] removeItemAtPath:stashPath
« no previous file with comments | « ios/chrome/browser/tabs/tab_model.mm ('k') | ios/shared/chrome/browser/tabs/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698