Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2639323003: Revert of Remove some ifdefs from ash since it only supports ChromeOS now. (Closed)

Created:
3 years, 11 months ago by Evan Stade
Modified:
3 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove some ifdefs from ash since it only supports ChromeOS now. (patchset #3 id:40001 of https://codereview.chromium.org/2631623003/ ) Reason for revert: ASH_EXPORT was necessary after all. Original issue's description: > Remove some ifdefs from ash since it only supports ChromeOS now. > > BUG=666773 > > Review-Url: https://codereview.chromium.org/2631623003 > Cr-Commit-Position: refs/heads/master@{#444590} > Committed: https://chromium.googlesource.com/chromium/src/+/4471855e032876c6194f5a414fa72f28b30e057d TBR=jamescook@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=666773 Review-Url: https://codereview.chromium.org/2639323003 Cr-Commit-Position: refs/heads/master@{#444601} Committed: https://chromium.googlesource.com/chromium/src/+/095fbc7f5a33b47c9506cecf8007e809552aa7b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -9 lines) Patch
M ash/display/display_configuration_controller.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M ash/display/display_util.h View 3 chunks +6 lines, -3 lines 0 comments Download
M ash/display/display_util.cc View 4 chunks +10 lines, -3 lines 0 comments Download
M ash/display/mirror_window_controller.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Evan Stade
Created Revert of Remove some ifdefs from ash since it only supports ChromeOS now.
3 years, 11 months ago (2017-01-19 02:09:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639323003/1
3 years, 11 months ago (2017-01-19 02:09:54 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 02:11:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/095fbc7f5a33b47c9506cecf8007...

Powered by Google App Engine
This is Rietveld 408576698