Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: ash/display/display_util.cc

Issue 2639323003: Revert of Remove some ifdefs from ash since it only supports ChromeOS now. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/display/display_util.h ('k') | ash/display/mirror_window_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/display/display_util.cc
diff --git a/ash/display/display_util.cc b/ash/display/display_util.cc
index 3ff0753cc2446e4629b83e4bae4be766823c5039..b87ffce0a60627451fd78d3d9cdce531f15d4291 100644
--- a/ash/display/display_util.cc
+++ b/ash/display/display_util.cc
@@ -14,12 +14,10 @@
#include "ash/display/null_mouse_warp_controller.h"
#include "ash/display/unified_mouse_warp_controller.h"
#include "ash/host/ash_window_tree_host.h"
-#include "ash/resources/vector_icons/vector_icons.h"
#include "ash/shell.h"
#include "base/memory/ptr_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/utf_string_conversions.h"
-#include "base/sys_info.h"
#include "grit/ash_strings.h"
#include "ui/aura/env.h"
#include "ui/aura/window_tree_host.h"
@@ -30,23 +28,30 @@
#include "ui/gfx/geometry/point.h"
#include "ui/gfx/geometry/rect.h"
#include "ui/gfx/geometry/size_conversions.h"
-#include "ui/gfx/paint_vector_icon.h"
#include "ui/message_center/message_center.h"
#include "ui/message_center/notification.h"
#include "ui/message_center/notification_delegate.h"
#include "ui/message_center/notification_list.h"
#include "ui/wm/core/coordinate_conversion.h"
+#if defined(OS_CHROMEOS)
+#include "ash/resources/vector_icons/vector_icons.h"
+#include "base/sys_info.h"
+#include "ui/gfx/paint_vector_icon.h"
+#endif
+
namespace ash {
namespace {
const char kDisplayErrorNotificationId[] = "chrome://settings/display/error";
+#if defined(OS_CHROMEOS)
// TODO(glevin): These are for new MD vector icons, but are using pre-MD color
// scheme. When we switch to all MD icons for notifications, these should be
// updated to use MD color scheme.
const SkColor kDisplayIconColor = SkColorSetRGB(0xBD, 0xBD, 0xBD);
const SkColor kFeedbackIconColor = SkColorSetRGB(0x96, 0x96, 0x98);
+#endif
// A notification delegate that will start the feedback app when the notication
// is clicked.
@@ -167,6 +172,7 @@
}
+#if defined(OS_CHROMEOS)
void ShowDisplayErrorNotification(const base::string16& message,
bool allow_feedback) {
// Always remove the notification to make sure the notification appears
@@ -197,6 +203,7 @@
message_center::MessageCenter::Get()->AddNotification(
std::move(notification));
}
+#endif
base::string16 GetDisplayErrorNotificationMessageForTest() {
message_center::NotificationList::Notifications notifications =
« no previous file with comments | « ash/display/display_util.h ('k') | ash/display/mirror_window_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698