Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2639233002: [Turbofan] Add CallFunctionWithSpread JSOperator. (Closed)

Created:
3 years, 11 months ago by petermarshall
Modified:
3 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
rmcilroy, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Add CallFunctionWithSpread JSOperator. Add the operator in preparation for actual perf work. The operator is replaced by the same runtime call as before, during lowering. BUG=v8:5511 Review-Url: https://codereview.chromium.org/2639233002 Cr-Commit-Position: refs/heads/master@{#42593} Committed: https://chromium.googlesource.com/v8/v8/+/53a887e4c682008f604a827c6885dcc6cd64eb53

Patch Set 1 #

Patch Set 2 : Remove dupe function #

Patch Set 3 : Set CL dependency to bytecode CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -10 lines) Patch
M src/compiler/bytecode-graph-builder.cc View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 2 2 chunks +26 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 1 2 2 chunks +32 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/operator-properties.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (13 generated)
petermarshall
PTAL =]
3 years, 11 months ago (2017-01-18 13:34:21 UTC) #4
Benedikt Meurer
LGTM on the compiler part (ideally you'd have the bytecode CL as dependency, so that ...
3 years, 11 months ago (2017-01-23 08:16:17 UTC) #11
petermarshall
On 2017/01/23 at 08:16:17, bmeurer wrote: > LGTM on the compiler part (ideally you'd have ...
3 years, 11 months ago (2017-01-23 08:29:00 UTC) #12
Benedikt Meurer
Aye, way better now :-)
3 years, 11 months ago (2017-01-23 08:29:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2639233002/40001
3 years, 11 months ago (2017-01-23 09:14:36 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 09:46:06 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/53a887e4c682008f604a827c6885dcc6cd6...

Powered by Google App Engine
This is Rietveld 408576698