[Turbofan] Implement call with spread bytecode in assembly code.

[Turbofan] Implement call with spread bytecode in assembly code.

We can share almost all of the architecture-specific builtin code with super-call-with-spread.

Info to port-writers: The code in CheckSpreadAndPushToStack has changed slightly from what was in Generate_ConstructWithSpread, in that we take the length of the spreaded parameters from the JSArray rather than the FixedArray backing store.

BUG=v8:5511
Review-Url: https://codereview.chromium.org/2649143002
Cr-Commit-Position: refs/heads/master@{#42632}
Committed: https://chromium.googlesource.com/v8/v8/+/f9367847b0e97e7238b4bfefbec79c8fbbc11056

[petermarshall, 2017-01-23 12:20:02]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 12:20:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 12:20:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 12:20:55]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/21329)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, no build URL)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/21413)

[petermarshall, 2017-01-23 13:58:08]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 13:58:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 13:59:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 13:59:03]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED, no build URL)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, no build URL)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED, no build URL)

[petermarshall, 2017-01-23 14:41:37]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 14:41:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 14:42:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 14:42:16]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/21343)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, no build URL)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/21428)

[petermarshall, 2017-01-23 15:13:25]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 15:13:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 15:14:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 15:14:18]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[petermarshall, 2017-01-23 15:18:02]

Description was changed from

==========
[Turbofan] Implement call with spread bytecode in assembly code.

BUG=v8:5511
==========

to

==========
[Turbofan] Implement call with spread bytecode in assembly code.

We can share almost all of the architecture-specific builtin code with
super-call-with-spread.

Info to port-writers: The code in CheckSpreadAndPushToStack has changed slightly
from what was in Generate_ConstructWithSpread, in that we take the length of the
spreaded parameters from the JSArray rather than the FixedArray backing store.

BUG=v8:5511
==========

[petermarshall, 2017-01-23 15:18:26]

petermarshall@chromium.org changed reviewers:
+ bmeurer@chromium.org, rmcilroy@chromium.org

[petermarshall, 2017-01-23 15:18:27]

PTAL =]

[rmcilroy, 2017-01-23 15:38:44]

Interpreter changes LGTM, thanks.

https://codereview.chromium.org/2649143002/diff/110001/src/builtins/arm/built...
File src/builtins/arm/builtins-arm.cc (right):

https://codereview.chromium.org/2649143002/diff/110001/src/builtins/arm/built...
src/builtins/arm/builtins-arm.cc:1150: MacroAssembler* masm, TailCallMode
tail_call_mode, PushArgsMode mode) {
nit - I'm not sure on the name, it seems a bit too generic (we push args in
other places). How about InterpreterPushArgsMode ?

[petermarshall, 2017-01-23 15:56:26]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 15:56:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 16:35:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 16:35:18]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2017-01-24 13:02:06]

LGTM

[petermarshall, 2017-01-24 14:34:51]

The CQ bit was checked by petermarshall@chromium.org

[petermarshall, 2017-01-24 14:34:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2649143002/#ps130001
(title: "Rename PushArgsMode to InterpreterPushArgsMode")

[commit-bot: I haz the power, 2017-01-24 14:35:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 14:37:01]

CQ is committing da patch.

Bot data: {"patchset_id": 130001, "attempt_start_ts": 1485268491153320,
"parent_rev": "4aedeb1bd50c12ebcd6cf954c4cbef1205fff5ac", "commit_rev":
"f9367847b0e97e7238b4bfefbec79c8fbbc11056"}

[commit-bot: I haz the power, 2017-01-24 14:37:06]

Description was changed from

==========
[Turbofan] Implement call with spread bytecode in assembly code.

We can share almost all of the architecture-specific builtin code with
super-call-with-spread.

Info to port-writers: The code in CheckSpreadAndPushToStack has changed slightly
from what was in Generate_ConstructWithSpread, in that we take the length of the
spreaded parameters from the JSArray rather than the FixedArray backing store.

BUG=v8:5511
==========

to

==========
[Turbofan] Implement call with spread bytecode in assembly code.

We can share almost all of the architecture-specific builtin code with
super-call-with-spread.

Info to port-writers: The code in CheckSpreadAndPushToStack has changed slightly
from what was in Generate_ConstructWithSpread, in that we take the length of the
spreaded parameters from the JSArray rather than the FixedArray backing store.

BUG=v8:5511

Review-Url: https://codereview.chromium.org/2649143002
Cr-Commit-Position: refs/heads/master@{#42632}
Committed:
https://chromium.googlesource.com/v8/v8/+/f9367847b0e97e7238b4bfefbec79c8fbbc...
==========

[commit-bot: I haz the power, 2017-01-24 14:37:07]

Committed patchset #8 (id:130001) as
https://chromium.googlesource.com/v8/v8/+/f9367847b0e97e7238b4bfefbec79c8fbbc...