Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 2639223002: [DO NOT COMMIT] Don't keep pointers to table sections when told to recalculate sections. (Closed)

Created:
3 years, 11 months ago by mstensho (USE GERRIT)
Modified:
3 years, 11 months ago
Reviewers:
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DO NOT COMMIT] Don't keep pointers to table sections when told to recalculate sections. Experiments to investigate the problems with landing https://codereview.chromium.org/2636153002/ Additions, compared to that CL: DCHECK in various mapToVisualRectInAncestorSpace() implementations that we're laid out.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 3 chunks +19 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
mstensho (USE GERRIT)
Description was changed from ========== [DO NOT COMMIT] Don't keep pointers to table sections when ...
3 years, 11 months ago (2017-01-18 13:10:10 UTC) #1
mstensho (USE GERRIT)
3 years, 11 months ago (2017-01-18 19:39:14 UTC) #2
Description was changed from

==========
[DO NOT COMMIT] Don't keep pointers to table sections when told to recalculate
sections.

They may have been deleted.

Assert in header(), footer() and firstBody() in LayoutTable that we're not
waiting for a section recalc.

This fixes the use-after-free issue with bug 680224, but now we get a (albeit
way more harmless) assertion failure instead.

BUG=680224

patch from issue 2636153002 at patchset 1 (http://crrev.com/2636153002#ps1)

DCHECK in various mapToVisualRectInAncestorSpace() implementations that we're
laid out.
==========

to

==========
[DO NOT COMMIT] Don't keep pointers to table sections when told to recalculate
sections.

Experiments to investigate the problems with landing
https://codereview.chromium.org/2636153002/

Additions, compared to that CL:

DCHECK in various mapToVisualRectInAncestorSpace() implementations that we're
laid out.
==========

Powered by Google App Engine
This is Rietveld 408576698