Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1785)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 2639223002: [DO NOT COMMIT] Don't keep pointers to table sections when told to recalculate sections. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2009 Google Inc. All rights reserved. 8 * Copyright (C) 2009 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
10 * (http://www.torchmobile.com/) 10 * (http://www.torchmobile.com/)
(...skipping 1290 matching lines...) Expand 10 before | Expand all | Expand 10 after
1301 } 1301 }
1302 1302
1303 bool LayoutObject::mapToVisualRectInAncestorSpace( 1303 bool LayoutObject::mapToVisualRectInAncestorSpace(
1304 const LayoutBoxModelObject* ancestor, 1304 const LayoutBoxModelObject* ancestor,
1305 LayoutRect& rect, 1305 LayoutRect& rect,
1306 VisualRectFlags visualRectFlags) const { 1306 VisualRectFlags visualRectFlags) const {
1307 // For any layout object that doesn't override this method (the main example 1307 // For any layout object that doesn't override this method (the main example
1308 // is LayoutText), the rect is assumed to be in the parent's coordinate space, 1308 // is LayoutText), the rect is assumed to be in the parent's coordinate space,
1309 // except for container flip. 1309 // except for container flip.
1310 1310
1311 DCHECK(!needsLayout());
1311 if (ancestor == this) 1312 if (ancestor == this)
1312 return true; 1313 return true;
1313 1314
1314 if (LayoutObject* parent = this->parent()) { 1315 if (LayoutObject* parent = this->parent()) {
1315 if (parent->isBox()) { 1316 if (parent->isBox()) {
1316 LayoutBox* parentBox = toLayoutBox(parent); 1317 LayoutBox* parentBox = toLayoutBox(parent);
1317 1318
1318 // Never flip for SVG as it handles writing modes itself. 1319 // Never flip for SVG as it handles writing modes itself.
1319 if (!isSVG()) 1320 if (!isSVG())
1320 parentBox->flipForWritingMode(rect); 1321 parentBox->flipForWritingMode(rect);
(...skipping 2187 matching lines...) Expand 10 before | Expand all | Expand 10 after
3508 const blink::LayoutObject* root = object1; 3509 const blink::LayoutObject* root = object1;
3509 while (root->parent()) 3510 while (root->parent())
3510 root = root->parent(); 3511 root = root->parent();
3511 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0); 3512 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
3512 } else { 3513 } else {
3513 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)"); 3514 WTFLogAlways("%s", "Cannot showLayoutTree. Root is (nil)");
3514 } 3515 }
3515 } 3516 }
3516 3517
3517 #endif 3518 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutTable.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698