Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2639223002: [DO NOT COMMIT] Don't keep pointers to table sections when told to recalculate sections. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTable.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2013 Apple Inc.
8 * All rights reserved. 8 * All rights reserved.
9 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 9 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
10 * 10 *
(...skipping 2045 matching lines...) Expand 10 before | Expand all | Expand 10 after
2056 return false; 2056 return false;
2057 } 2057 }
2058 2058
2059 return true; 2059 return true;
2060 } 2060 }
2061 2061
2062 bool LayoutTableSection::mapToVisualRectInAncestorSpace( 2062 bool LayoutTableSection::mapToVisualRectInAncestorSpace(
2063 const LayoutBoxModelObject* ancestor, 2063 const LayoutBoxModelObject* ancestor,
2064 LayoutRect& rect, 2064 LayoutRect& rect,
2065 VisualRectFlags flags) const { 2065 VisualRectFlags flags) const {
2066 DCHECK(!needsLayout());
2066 if (ancestor == this) 2067 if (ancestor == this)
2067 return true; 2068 return true;
2068 // Repeating table headers are painted once per fragmentation page/column. 2069 // Repeating table headers are painted once per fragmentation page/column.
2069 // This does not go through the regular fragmentation machinery, so we need 2070 // This does not go through the regular fragmentation machinery, so we need
2070 // special code to expand the invalidation rect to contain all positions of 2071 // special code to expand the invalidation rect to contain all positions of
2071 // the header in all columns. 2072 // the header in all columns.
2072 // Note that this is in flow thread coordinates, not visual coordinates. The 2073 // Note that this is in flow thread coordinates, not visual coordinates. The
2073 // enclosing LayoutFlowThread will convert to visual coordinates. 2074 // enclosing LayoutFlowThread will convert to visual coordinates.
2074 if (table()->header() == this && isRepeatingHeaderGroup()) 2075 if (table()->header() == this && isRepeatingHeaderGroup())
2075 rect.setHeight(table()->logicalHeight()); 2076 rect.setHeight(table()->logicalHeight());
2076 return LayoutTableBoxComponent::mapToVisualRectInAncestorSpace(ancestor, rect, 2077 return LayoutTableBoxComponent::mapToVisualRectInAncestorSpace(ancestor, rect,
2077 flags); 2078 flags);
2078 } 2079 }
2079 2080
2080 } // namespace blink 2081 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTable.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698