Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2639213002:
Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. (Closed)
DescriptionAdds four benchmarks to measure v8 runtime + GC metrics on browsing story set.
Adds four benchmarks (v8.runtimestats.browsing_desktop,
v8.runtimestats.browsing_desktop_turbo, v8.runtimestats.browsing_mobile,
v8.runtimestats.browsing_mobile_turbo) to measure v8 RuntimeStatsMetric +
v8 GC metrics on the browsing story set. v8.runtimestats.browsing_desktop,
v8.runtimestats.browsing_desktop_turbo are for the desktop platform
and the other two are for mobile platform. On each platform, one benchmark
measures the current default configuration of v8 and the second one measures
the intended shipping configuration with the new pipeline.
BUG=chromium:690921
Review-Url: https://codereview.chromium.org/2639213002
Cr-Commit-Position: refs/heads/master@{#451301}
Committed: https://chromium.googlesource.com/chromium/src/+/6ff9bc4874fe92fad720b9b88715a48c97576689
Patch Set 1 #Patch Set 2 : Format fix. Removed an extra line. #Patch Set 3 : Rebased the patch. #
Total comments: 1
Patch Set 4 : Updated desktop benchmarks and adding mobile benchmarks. #
Total comments: 1
Patch Set 5 : Also collect GC metrics. #
Total comments: 4
Patch Set 6 : Only enable GC metric along with RCS. #
Total comments: 2
Patch Set 7 : Remove categories not needed for gcMetric. #Messages
Total messages: 56 (34 generated)
Description was changed from ========== Adds benchmarks to measure v8 runtime stats on browsing story set. Adds two benchmarks to measure v8 metrics using RuntimeStatsMetric on the browsing story set. One benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. ========== to ========== Adds benchmarks to measure v8 runtime stats on browsing story set. Adds two benchmarks to measure v8 metrics using RuntimeStatsMetric on the browsing story set. One benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
mythria@chromium.org changed reviewers: + cbruni@chromium.org, nednguyen@google.com, rmcilroy@chromium.org
Hi, This cl adds two benchmarks to measure v8 related metrics using runtimeStats on the browse story set. We need this benchmarks to measure the performance of v8 on the real world interactive web pages. We need two of them to measure the performance of the new pipeline with the current one. Once the new pipeline ships we can remove one of the benchmarks. We tried to enable runtimeStats on the existing v8 browse benchmarks that measure GC related metrics. However, enabling runtimeStats impacts the execution time by about 10% which is not acceptable to measure some of the GC related metrics like GC related jank. PTAL. Thanks, Mythri
Description was changed from ========== Adds benchmarks to measure v8 runtime stats on browsing story set. Adds two benchmarks to measure v8 metrics using RuntimeStatsMetric on the browsing story set. One benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Adds benchmarks to measure v8 runtime stats on browsing story set. Adds two benchmarks to measure v8 metrics using RuntimeStatsMetric on the browsing story set. One benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
nednguyen@google.com changed reviewers: + ulan@chromium.org
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2639213002/diff/40001/tools/perf/benchmarks/v... File tools/perf/benchmarks/v8_browsing.py (right): https://codereview.chromium.org/2639213002/diff/40001/tools/perf/benchmarks/v... tools/perf/benchmarks/v8_browsing.py:104: tbm_options.SetTimelineBasedMetrics(['runtimeStatsInteractiveMetric']) This should now be runtimeStatsTotalMetric, no? Also, I think it would make sense to also add the runtimeStatsMetric, even though we focus on browsing, we are still interested in startup? I'd be also interested in seeing what the ratio between the startup and total metric is going to be.
On Thu, Jan 19, 2017 at 7:08 PM, <cbruni@chromium.org> wrote: > > https://codereview.chromium.org/2639213002/diff/40001/ > tools/perf/benchmarks/v8_browsing.py > File tools/perf/benchmarks/v8_browsing.py (right): > > https://codereview.chromium.org/2639213002/diff/40001/ > tools/perf/benchmarks/v8_browsing.py#newcode104 > tools/perf/benchmarks/v8_browsing.py:104: > tbm_options.SetTimelineBasedMetrics(['runtimeStatsInteractiveMetric']) > This should now be runtimeStatsTotalMetric, no? > > Also, I think it would make sense to also add the runtimeStatsMetric, > even though we focus on browsing, we are still interested in startup? > I'd be also interested in seeing what the ratio between the startup and > total metric is going to be. > > Yes, I think that is a good idea. I tried adding startup metric as well. It fails on several pages in the funciton computeInteractiveTime from runtime_stats_metric.html. I will check with Fadi, and once I get it to work, I will enable startup time as well. https://codereview.chromium.org/2639213002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Is it be possible to add the runtime call stats to the existing browsing benchmark?
On 2017/02/08 11:27:01, ulan (slow response travel) wrote: > Is it be possible to add the runtime call stats to the existing browsing > benchmark? It is a bit expensive to collect RuntimeStats. It increases the v8 execution time by 10-14%. This could impact the latency measurements on the existing browse benchmarks. So, we decided to add them as a new benchmark. Thanks, Mythri.
https://codereview.chromium.org/2639213002/diff/60001/tools/perf/benchmarks/v... File tools/perf/benchmarks/v8_browsing.py (right): https://codereview.chromium.org/2639213002/diff/60001/tools/perf/benchmarks/v... tools/perf/benchmarks/v8_browsing.py:109: tbm_options.SetTimelineBasedMetrics(['runtimeStatsTotalMetric']) Could you add the GC metrics as well here? (I presume this is the right place)
Description was changed from ========== Adds benchmarks to measure v8 runtime stats on browsing story set. Adds two benchmarks to measure v8 metrics using RuntimeStatsMetric on the browsing story set. One benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Adds benchmarks to measure v8 runtime stats on browsing story set. Adds two benchmarks to measure v8 metrics using RuntimeStatsMetric on the browsing story set. One benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== Adds benchmarks to measure v8 runtime stats on browsing story set. Adds two benchmarks to measure v8 metrics using RuntimeStatsMetric on the browsing story set. One benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Adds benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds two benchmarks to measure v8 metrics using RuntimeStatsMetric on the browsing story set. One benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
lgtm
On 2017/02/13 20:20:12, Camillo Bruni wrote: > lgtm Can you update your description to clearly state that you're adding 4 benchmarks?
https://codereview.chromium.org/2639213002/diff/80001/tools/perf/benchmarks/v... File tools/perf/benchmarks/v8_browsing.py (right): https://codereview.chromium.org/2639213002/diff/80001/tools/perf/benchmarks/v... tools/perf/benchmarks/v8_browsing.py:109: options.AddTimelineBasedMetric('runtimeStatsTotalMetric') Also wouldn't you also enable GC metrics?
The metric used by this benchmark has not landed yet, but is quite close to landing (https://codereview.chromium.org/2639993002/). Could you please take a look at this cl. I will land this cl after the metric lands. The results from these benchmarks look like this: https://mythria.users.x20web.corp.google.com/www/results_all.html PTAL. Thanks, Mythri https://codereview.chromium.org/2639213002/diff/80001/tools/perf/benchmarks/v... File tools/perf/benchmarks/v8_browsing.py (right): https://codereview.chromium.org/2639213002/diff/80001/tools/perf/benchmarks/v... tools/perf/benchmarks/v8_browsing.py:109: options.AddTimelineBasedMetric('runtimeStatsTotalMetric') On 2017/02/13 20:28:22, nednguyen wrote: > Also wouldn't you also enable GC metrics? I made this a subclass of V8 browsing benchmark, so the GC metrics are already set when I call super on the first line. If this is not a good design, I will change it and just share the code for setting options and not make this a subclass of V8BrowsingBenchmark.
lgtm
On 2017/02/14 14:48:30, mythria wrote: > The metric used by this benchmark has not landed yet, but is quite close to > landing (https://codereview.chromium.org/2639993002/). Could you please take a > look at this cl. I will land this cl after the metric lands. If you have other reviewers' stamp, no need to wait on me :-) > > The results from these benchmarks look like this: > https://mythria.users.x20web.corp.google.com/www/results_all.html > > PTAL. > > Thanks, > Mythri > > https://codereview.chromium.org/2639213002/diff/80001/tools/perf/benchmarks/v... > File tools/perf/benchmarks/v8_browsing.py (right): > > https://codereview.chromium.org/2639213002/diff/80001/tools/perf/benchmarks/v... > tools/perf/benchmarks/v8_browsing.py:109: > options.AddTimelineBasedMetric('runtimeStatsTotalMetric') > On 2017/02/13 20:28:22, nednguyen wrote: > > Also wouldn't you also enable GC metrics? > > I made this a subclass of V8 browsing benchmark, so the GC metrics are already > set when I call super on the first line. If this is not a good design, I will > change it and just share the code for setting options and not make this a > subclass of V8BrowsingBenchmark. Ping on update the description of the CL to state the benchmarks you're adding. Also who should I put as owners for these benchmarks?
https://codereview.chromium.org/2639213002/diff/80001/tools/perf/benchmarks/v... File tools/perf/benchmarks/v8_browsing.py (right): https://codereview.chromium.org/2639213002/diff/80001/tools/perf/benchmarks/v... tools/perf/benchmarks/v8_browsing.py:109: options.AddTimelineBasedMetric('runtimeStatsTotalMetric') On 2017/02/14 14:48:30, mythria wrote: > On 2017/02/13 20:28:22, nednguyen wrote: > > Also wouldn't you also enable GC metrics? > > I made this a subclass of V8 browsing benchmark, so the GC metrics are already > set when I call super on the first line. If this is not a good design, I will > change it and just share the code for setting options and not make this a > subclass of V8BrowsingBenchmark. The problem with this approach is besides GC, it would also include the v8_execution_metrics. Can you change this so the metrics is just gc_metrics + v8 runtime callstats metrics?
Description was changed from ========== Adds benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds two benchmarks to measure v8 metrics using RuntimeStatsMetric on the browsing story set. One benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. Two of these benchmarks are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. Two of these benchmarks are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. Two of these benchmarks are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. Two of these benchmarks are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. Two of these benchmarks are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
I updated the benchmark to measure only GCMetric + RCS. PTAL. Thanks, Mythri. https://codereview.chromium.org/2639213002/diff/80001/tools/perf/benchmarks/v... File tools/perf/benchmarks/v8_browsing.py (right): https://codereview.chromium.org/2639213002/diff/80001/tools/perf/benchmarks/v... tools/perf/benchmarks/v8_browsing.py:109: options.AddTimelineBasedMetric('runtimeStatsTotalMetric') On 2017/02/14 15:05:25, nednguyen wrote: > On 2017/02/14 14:48:30, mythria wrote: > > On 2017/02/13 20:28:22, nednguyen wrote: > > > Also wouldn't you also enable GC metrics? > > > > I made this a subclass of V8 browsing benchmark, so the GC metrics are already > > set when I call super on the first line. If this is not a good design, I will > > change it and just share the code for setting options and not make this a > > subclass of V8BrowsingBenchmark. > > The problem with this approach is besides GC, it would also include the > v8_execution_metrics. Can you change this so the metrics is just gc_metrics + v8 > runtime callstats metrics? Thanks, Done. https://codereview.chromium.org/2639213002/diff/100001/tools/perf/benchmarks/... File tools/perf/benchmarks/v8_browsing.py (right): https://codereview.chromium.org/2639213002/diff/100001/tools/perf/benchmarks/... tools/perf/benchmarks/v8_browsing.py:115: ] Ulan, can I remove any of these categories that are not required by gcMetric?
On 2017/02/14 16:05:34, mythria wrote: > I updated the benchmark to measure only GCMetric + RCS. > > PTAL. > > Thanks, > Mythri. > > https://codereview.chromium.org/2639213002/diff/80001/tools/perf/benchmarks/v... > File tools/perf/benchmarks/v8_browsing.py (right): > > https://codereview.chromium.org/2639213002/diff/80001/tools/perf/benchmarks/v... > tools/perf/benchmarks/v8_browsing.py:109: > options.AddTimelineBasedMetric('runtimeStatsTotalMetric') > On 2017/02/14 15:05:25, nednguyen wrote: > > On 2017/02/14 14:48:30, mythria wrote: > > > On 2017/02/13 20:28:22, nednguyen wrote: > > > > Also wouldn't you also enable GC metrics? > > > > > > I made this a subclass of V8 browsing benchmark, so the GC metrics are > already > > > set when I call super on the first line. If this is not a good design, I > will > > > change it and just share the code for setting options and not make this a > > > subclass of V8BrowsingBenchmark. > > > > The problem with this approach is besides GC, it would also include the > > v8_execution_metrics. Can you change this so the metrics is just gc_metrics + > v8 > > runtime callstats metrics? > > Thanks, Done. > > https://codereview.chromium.org/2639213002/diff/100001/tools/perf/benchmarks/... > File tools/perf/benchmarks/v8_browsing.py (right): > > https://codereview.chromium.org/2639213002/diff/100001/tools/perf/benchmarks/... > tools/perf/benchmarks/v8_browsing.py:115: ] > Ulan, can I remove any of these categories that are not required by gcMetric? Can you add the names of the benchmarks you're adding to the description as well? lgtm & feel free to land after Ulan answers your equestion
Description was changed from ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. Two of these benchmarks are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks (v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo, v8.runtimestats.browsing_mobile, v8.runtimestats.browsing_mobile_turbo) to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks (v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo, v8.runtimestats.browsing_mobile, v8.runtimestats.browsing_mobile_turbo) to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks (v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo, v8.runtimestats.browsing_mobile, v8.runtimestats.browsing_mobile_turbo) to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks (v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo, v8.runtimestats.browsing_mobile, v8.runtimestats.browsing_mobile_turbo) to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks (v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo, v8.runtimestats.browsing_mobile, v8.runtimestats.browsing_mobile_turbo) to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks (v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo, v8.runtimestats.browsing_mobile, v8.runtimestats.browsing_mobile_turbo) to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks (v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo, v8.runtimestats.browsing_mobile, v8.runtimestats.browsing_mobile_turbo) to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
After an offline discussion with Ulan, removed a category that is not required. The metric used by this benchmark also landed. I will go ahead and land this cl. Thanks, Mythri https://codereview.chromium.org/2639213002/diff/100001/tools/perf/benchmarks/... File tools/perf/benchmarks/v8_browsing.py (right): https://codereview.chromium.org/2639213002/diff/100001/tools/perf/benchmarks/... tools/perf/benchmarks/v8_browsing.py:115: ] On 2017/02/14 16:05:34, mythria wrote: > Ulan, can I remove any of these categories that are not required by gcMetric? Had a offline discussion with Ulan and removed disabled-by-default-memory-infra.v8.code_stats which is only required for code size measurements.
The CQ bit was checked by mythria@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, no build URL) mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, no build URL) winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, no build URL)
On 2017/02/16 15:48:25, mythria wrote: > After an offline discussion with Ulan, removed a category that is not required. > The metric used by this benchmark also landed. I will go ahead and land this cl. > > Thanks, > Mythri > > https://codereview.chromium.org/2639213002/diff/100001/tools/perf/benchmarks/... > File tools/perf/benchmarks/v8_browsing.py (right): > > https://codereview.chromium.org/2639213002/diff/100001/tools/perf/benchmarks/... > tools/perf/benchmarks/v8_browsing.py:115: ] > On 2017/02/14 16:05:34, mythria wrote: > > Ulan, can I remove any of these categories that are not required by gcMetric? > > Had a offline discussion with Ulan and removed > disabled-by-default-memory-infra.v8.code_stats which is only required for code > size measurements. Who should I add as owner for these benchmarks in go/chrome-benchmarks?
On Thu, Feb 16, 2017 at 3:51 PM, <nednguyen@google.com> wrote: > On 2017/02/16 15:48:25, mythria wrote: > > After an offline discussion with Ulan, removed a category that is not > required. > > The metric used by this benchmark also landed. I will go ahead and land > this > cl. > > > > Thanks, > > Mythri > > > > > https://codereview.chromium.org/2639213002/diff/100001/ > tools/perf/benchmarks/v8_browsing.py > > File tools/perf/benchmarks/v8_browsing.py (right): > > > > > https://codereview.chromium.org/2639213002/diff/100001/ > tools/perf/benchmarks/v8_browsing.py#newcode115 > > tools/perf/benchmarks/v8_browsing.py:115: ] > > On 2017/02/14 16:05:34, mythria wrote: > > > Ulan, can I remove any of these categories that are not required by > gcMetric? > > > > Had a offline discussion with Ulan and removed > > disabled-by-default-memory-infra.v8.code_stats which is only required > for code > > size measurements. > > Who should I add as owner for these benchmarks in go/chrome-benchmarks > <https://goto.google.com/chrome-benchmarks>? > Hi Ned, you could either add cbruni@ or myself (mythria@) . > https://codereview.chromium.org/2639213002/ > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by mythria@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org, cbruni@chromium.org, nednguyen@google.com Link to the patchset: https://codereview.chromium.org/2639213002/#ps120001 (title: "Remove categories not needed for gcMetric.")
The CQ bit was unchecked by mythria@chromium.org
The CQ bit was checked by mythria@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, no build URL) mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, no build URL) winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, no build URL)
Description was changed from ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks (v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo, v8.runtimestats.browsing_mobile, v8.runtimestats.browsing_mobile_turbo) to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks (v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo, v8.runtimestats.browsing_mobile, v8.runtimestats.browsing_mobile_turbo) to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 ==========
The CQ bit was checked by mythria@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487340785912950,
"parent_rev": "769ab95c120512f2a02cba01a805cce00d651859", "commit_rev":
"6ff9bc4874fe92fad720b9b88715a48c97576689"}
Message was sent while issue was closed.
Description was changed from ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks (v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo, v8.runtimestats.browsing_mobile, v8.runtimestats.browsing_mobile_turbo) to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 ========== to ========== Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set. Adds four benchmarks (v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo, v8.runtimestats.browsing_mobile, v8.runtimestats.browsing_mobile_turbo) to measure v8 RuntimeStatsMetric + v8 GC metrics on the browsing story set. v8.runtimestats.browsing_desktop, v8.runtimestats.browsing_desktop_turbo are for the desktop platform and the other two are for mobile platform. On each platform, one benchmark measures the current default configuration of v8 and the second one measures the intended shipping configuration with the new pipeline. BUG=chromium:690921 Review-Url: https://codereview.chromium.org/2639213002 Cr-Commit-Position: refs/heads/master@{#451301} Committed: https://chromium.googlesource.com/chromium/src/+/6ff9bc4874fe92fad720b9b88715... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/6ff9bc4874fe92fad720b9b88715... |
