Adds four benchmarks to measure v8 runtime + GC metrics on browsing story set.

tools/perf/benchmarks/v8_browsing.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import re
 
 from benchmarks import v8_helper
 from core import perf_benchmark
 from telemetry import benchmark
 from telemetry.timeline import chrome_trace_config
@@ skipping 68 matching lines @@
       return ('renderer_processes' in value.name and
               not _IGNORED_MEMORY_STATS_RE.search(value.name))
     return (_V8_GC_HIGH_LEVEL_STATS_RE.search(value.name) and
             not _IGNORED_V8_STATS_RE.search(value.name))
 
   @classmethod
   def ShouldTearDownStateAfterEachStoryRun(cls):
     return True
 
 
+class _V8RuntimeStatsBrowsingBenchmark(_V8BrowsingBenchmark):
+  """Base class for V8 browsing benchmarks that measure RuntimeStats.
+  RuntimeStats measure the time spent by v8 in different phases like
+  compile, JS execute, runtime etc.,
+  See browsing_stories._BrowsingStory for workload description.
+  """
+
+  def CreateTimelineBasedMeasurementOptions(self):
+    # Adds options for GC and v8 execution metrics.
+    options = super(_V8RuntimeStatsBrowsingBenchmark,
+              self).CreateTimelineBasedMeasurementOptions()
+
+    # Add options for runtime stats metric.
+    options.category_filter.AddIncludedCategory('v8')
+    options.category_filter.AddDisabledByDefault(
+              'disabled-by-default-v8.runtime_stats')
+
+    # Enable rail to bucket runtime stats based on UE.
+    options.category_filter.AddIncludedCategory('rail')
+
+    options.AddTimelineBasedMetric('runtimeStatsTotalMetric')

[nednguyen, 2017/02/13 20:28:22]

Also wouldn't you also enable GC metrics?

[mythria, 2017/02/14 14:48:30]

I made this a subclass of V8 browsing benchmark, so the GC metrics are already
set when I call super on the first line. If this is not a good design, I will
change it and just share the code for setting options and not make this a
subclass of V8BrowsingBenchmark.

[nednguyen, 2017/02/14 15:05:25]

The problem with this approach is besides GC, it would also include the
v8_execution_metrics. Can you change this so the metrics is just gc_metrics + v8
runtime callstats metrics?

[mythria, 2017/02/14 16:05:34]

Thanks, Done.

+    return options
+
+  @classmethod
+  def Name(cls):
+    return 'v8.runtimestats.browsing_%s%s' % (cls.PLATFORM, cls.TEST_SUFFIX)
+
+  @classmethod
+  def ShouldTearDownStateAfterEachStoryRun(cls):
+    return True
+
+
 class _V8DesktopBrowsingBenchmark(_V8BrowsingBenchmark):
 
   @classmethod
   def ShouldDisable(cls, possible_browser):
     # http://crbug.com/628736
     if (possible_browser.platform.GetOSName() == 'mac' and
         possible_browser.browser_type == 'reference'):
       return True
 
     return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
@@ skipping 49 matching lines @@
 
 
 @benchmark.Disabled('reference')  # http://crbug.com/628631
 class V8MobileTurboBrowsingBenchmark(_V8MobileBrowsingBenchmark):
   PLATFORM = 'mobile'
   TEST_SUFFIX = '_turbo'
 
   def SetExtraBrowserOptions(self, options):
     super(V8MobileTurboBrowsingBenchmark, self).SetExtraBrowserOptions(
         options)
+
+
+class V8RuntimeStatsDesktopBrowsingBenchmark(
+    _V8RuntimeStatsBrowsingBenchmark):
+  PLATFORM = 'desktop'
+  TEST_SUFFIX = ''
+
+  @classmethod
+  def ShouldDisable(cls, possible_browser):
+    return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
+
+
+class V8RuntimeStatsDesktopTurboBrowsingBenchmark(
+    _V8RuntimeStatsBrowsingBenchmark):
+  PLATFORM = 'desktop'
+  TEST_SUFFIX = '_turbo'
+
+  def SetExtraBrowserOptions(self, options):
+    super(V8RuntimeStatsDesktopTurboBrowsingBenchmark,
+        self).SetExtraBrowserOptions(options)
     v8_helper.EnableTurbo(options)
+
+  @classmethod
+  def ShouldDisable(cls, possible_browser):
+    return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
+
+
+class V8RuntimeStatsMobileBrowsingBenchmark(
+    _V8RuntimeStatsBrowsingBenchmark):
+  PLATFORM = 'mobile'
+  TEST_SUFFIX = ''
+
+  def SetExtraBrowserOptions(self, options):
+    super(V8RuntimeStatsMobileBrowsingBenchmark,
+        self).SetExtraBrowserOptions(options)
+    v8_helper.EnableTurbo(options)
+
+  @classmethod
+  def ShouldDisable(cls, possible_browser):
+    return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
+
+
+class V8RuntimeStatsMobileTurboBrowsingBenchmark(
+    _V8RuntimeStatsBrowsingBenchmark):
+  PLATFORM = 'mobile'
+  TEST_SUFFIX = '_turbo'
+
+  def SetExtraBrowserOptions(self, options):
+    super(V8RuntimeStatsMobileTurboBrowsingBenchmark,
+        self).SetExtraBrowserOptions(options)
+    v8_helper.EnableTurbo(options)
+
+  @classmethod
+  def ShouldDisable(cls, possible_browser):
+    return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
+