Use loading tq instead of timer tq for per-isolate tasks

Use loading tq instead of timer tq for per-isolate tasks

When per-isolate tasks are posted to timer tq, memory usage metrics go up.
This may happen due to garbage collection being throttled. Switch tasks to
loading task queue to fix regression for now.

R=haraken@chromium.org
CC=skyostil@chromium.org,primiano@chromium.org

BUG=678286, 676805
Review-Url: https://codereview.chromium.org/2638973002
Cr-Commit-Position: refs/heads/master@{#444327}
Committed: https://chromium.googlesource.com/chromium/src/+/4f45c5de5f5444ffb697790c76387e66502d079f

[altimin, 2017-01-17 18:56:37]

PTAL

[altimin, 2017-01-17 19:29:49]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 19:30:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2017-01-17 19:30:35]

skyostil@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2017-01-17 19:30:36]

lgtm for now. I'm not sure of what the long term solution here is -- perhaps we
just need to expose more than one type of task queue for different work?

[commit-bot: I haz the power, 2017-01-17 20:47:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 20:47:39]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-01-18 00:05:03]

LGTM

https://codereview.chromium.org/2638973002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):

https://codereview.chromium.org/2638973002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:397: //
TODO(altimin): Consider switching to timerTaskRunner here.

Add a comment and mention that we use a loading tq to prevent GC tasks from
being throttled.

https://codereview.chromium.org/2638973002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:399: scheduler ?
scheduler->loadingTaskRunner()

Maybe do we want to use an unthrottled task runner?

[altimin, 2017-01-18 10:23:32]

The CQ bit was checked by altimin@chromium.org

[commit-bot: I haz the power, 2017-01-18 10:23:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 10:27:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484735012412260, "parent_rev":
"2c23e03abf26b84bb46a1eff47334084f592e028", "commit_rev":
"4f45c5de5f5444ffb697790c76387e66502d079f"}

[commit-bot: I haz the power, 2017-01-18 10:27:57]

Description was changed from

==========
Use loading tq instead of timer tq for per-isolate tasks

When per-isolate tasks are posted to timer tq, memory usage metrics go up.
This may happen due to garbage collection being throttled. Switch tasks to
loading task queue to fix regression for now.

R=haraken@chromium.org
CC=skyostil@chromium.org,primiano@chromium.org

BUG=678286,676805
==========

to

==========
Use loading tq instead of timer tq for per-isolate tasks

When per-isolate tasks are posted to timer tq, memory usage metrics go up.
This may happen due to garbage collection being throttled. Switch tasks to
loading task queue to fix regression for now.

R=haraken@chromium.org
CC=skyostil@chromium.org,primiano@chromium.org

BUG=678286,676805

Review-Url: https://codereview.chromium.org/2638973002
Cr-Commit-Position: refs/heads/master@{#444327}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f45c5de5f5444ffb697790c7638...
==========

[commit-bot: I haz the power, 2017-01-18 10:27:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f45c5de5f5444ffb697790c7638...

[altimin, 2017-01-18 13:07:09]

https://codereview.chromium.org/2638973002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp (right):

https://codereview.chromium.org/2638973002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp:399: scheduler ?
scheduler->loadingTaskRunner()
On 2017/01/18 00:05:03, haraken wrote:
> 
> Maybe do we want to use an unthrottled task runner?

Most probably we need to expose different task runners to isolate and route
appropriate tasks to appropriate queues.