Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp

Issue 2638973002: Use loading tq instead of timer tq for per-isolate tasks (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
index 347c27bc822eeade5ec98a269aec2b81f2afe953..c6fb0b8bf409eba75fb11b89b8f5faab345f599e 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
@@ -394,8 +394,9 @@ void V8Initializer::initializeMainThread() {
// NOTE: Some threads (namely utility threads) don't have a scheduler.
WebScheduler* scheduler = Platform::current()->currentThread()->scheduler();
+ // TODO(altimin): Consider switching to timerTaskRunner here.
haraken 2017/01/18 00:05:03 Add a comment and mention that we use a loading tq
v8::Isolate* isolate = V8PerIsolateData::initialize(
- scheduler ? scheduler->timerTaskRunner()
+ scheduler ? scheduler->loadingTaskRunner()
haraken 2017/01/18 00:05:03 Maybe do we want to use an unthrottled task runner
altimin 2017/01/18 13:07:09 Most probably we need to expose different task run
: Platform::current()->currentThread()->getWebTaskRunner());
initializeV8Common(isolate);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698