MD WebUI: Remove WebUI test focus hack by moving to interactive ui tests

MD WebUI: Remove WebUI test focus hack by moving to interactive ui tests

WebUIBrowserTest currently has a workaround to focus the test window
when starting a test. However, tests which rely on focus will still
often fail when run in parallel with other tests.

This CL removes this workaround and moves the affected tests to
interactive ui tests, which run serially and are able to reliably focus
their WebContents before running.

BUG=642467
Review-Url: https://codereview.chromium.org/2638843002
Cr-Commit-Position: refs/heads/master@{#444536}
Committed: https://chromium.googlesource.com/chromium/src/+/fb7b4ef61424259ad589b83efa6dd41e682299cf

[tsergeant, 2017-01-17 00:46:45]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 00:46:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 01:48:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 01:48:31]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-01-17 02:24:09]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 02:24:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 03:15:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 03:15:22]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-01-17 03:58:14]

Description was changed from

==========
MD WebUI: Remove WebUI test focus hack by moving to interactive ui tests

WIP

BUG=642467
==========

to

==========
MD WebUI: Remove WebUI test focus hack by moving to interactive ui tests

WebUIBrowserTest currently has a workaround to focus the test window
when starting a test. These tests will still often fail when run in
parallel with other tests.

This CL removes this workaround and moves the affected tests to
interactive ui tests, which run serially and are able to reliably focus
their WebContents before running.

BUG=642467
==========

[tsergeant, 2017-01-17 04:09:22]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 04:09:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 05:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 05:13:34]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-01-17 06:41:42]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 06:41:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-01-17 06:42:41]

Patchset #1 (id:1) has been deleted

[tsergeant, 2017-01-17 06:43:30]

tsergeant@chromium.org changed reviewers:
+ dbeam@chromium.org

[tsergeant, 2017-01-17 06:43:30]

As a follow-up to the CL from last week, this completes the process of moving to
interactive UI tests. PTAL

[commit-bot: I haz the power, 2017-01-17 07:35:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 07:35:56]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-01-18 02:02:57]

cool!  lgtm

[tsergeant, 2017-01-18 02:12:40]

Description was changed from

==========
MD WebUI: Remove WebUI test focus hack by moving to interactive ui tests

WebUIBrowserTest currently has a workaround to focus the test window
when starting a test. These tests will still often fail when run in
parallel with other tests.

This CL removes this workaround and moves the affected tests to
interactive ui tests, which run serially and are able to reliably focus
their WebContents before running.

BUG=642467
==========

to

==========
MD WebUI: Remove WebUI test focus hack by moving to interactive ui tests

WebUIBrowserTest currently has a workaround to focus the test window
when starting a test. However, tests which rely on focus will still
often fail when run in parallel with other tests.

This CL removes this workaround and moves the affected tests to
interactive ui tests, which run serially and are able to reliably focus
their WebContents before running.

BUG=642467
==========

[tsergeant, 2017-01-18 02:13:32]

tsergeant@chromium.org changed reviewers:
+ sky@chromium.org

[tsergeant, 2017-01-18 02:13:32]

+sky@ for the change to web_ui_browser_test.cc

[sky, 2017-01-18 16:49:15]

LGTM

[tsergeant, 2017-01-18 22:14:42]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-01-18 22:15:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 23:12:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484777682524370,
"parent_rev": "ade86406b4ae2364453e210587ab00ed072e3106", "commit_rev":
"fb7b4ef61424259ad589b83efa6dd41e682299cf"}

[commit-bot: I haz the power, 2017-01-18 23:12:45]

Description was changed from

==========
MD WebUI: Remove WebUI test focus hack by moving to interactive ui tests

WebUIBrowserTest currently has a workaround to focus the test window
when starting a test. However, tests which rely on focus will still
often fail when run in parallel with other tests.

This CL removes this workaround and moves the affected tests to
interactive ui tests, which run serially and are able to reliably focus
their WebContents before running.

BUG=642467
==========

to

==========
MD WebUI: Remove WebUI test focus hack by moving to interactive ui tests

WebUIBrowserTest currently has a workaround to focus the test window
when starting a test. However, tests which rely on focus will still
often fail when run in parallel with other tests.

This CL removes this workaround and moves the affected tests to
interactive ui tests, which run serially and are able to reliably focus
their WebContents before running.

BUG=642467

Review-Url: https://codereview.chromium.org/2638843002
Cr-Commit-Position: refs/heads/master@{#444536}
Committed:
https://chromium.googlesource.com/chromium/src/+/fb7b4ef61424259ad589b83efa6d...
==========

[commit-bot: I haz the power, 2017-01-18 23:12:47]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fb7b4ef61424259ad589b83efa6d...