Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3147)

Unified Diff: chrome/test/base/web_ui_browser_test.cc

Issue 2638843002: MD WebUI: Remove WebUI test focus hack by moving to interactive ui tests (Closed)
Patch Set: Ui -> UI Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/BUILD.gn ('k') | chrome/test/data/webui/cr_elements/cr_action_menu_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/web_ui_browser_test.cc
diff --git a/chrome/test/base/web_ui_browser_test.cc b/chrome/test/base/web_ui_browser_test.cc
index c50a43458e417ea7807b06f0105ac1e20acec35d..4c8d5bc7c8ad02b2d21baf452880de543058013c 100644
--- a/chrome/test/base/web_ui_browser_test.cc
+++ b/chrome/test/base/web_ui_browser_test.cc
@@ -224,16 +224,6 @@ void WebUIBrowserTest::BrowsePreload(const GURL& browse_to) {
browser(), GURL(browse_to), ui::PAGE_TRANSITION_TYPED);
params.disposition = WindowOpenDisposition::CURRENT_TAB;
- // This is needed to make the test
- // MaterialHistoryBrowserTest.HistoryToolbarFocusTest pass on macOS. The test
- // is fundamentally flawed, since it expects a particular widget to be
- // focused. Chrome focus semantics are based on the Windows platform, where a
- // widget cannot be focused without window activation. browser_tests can be
- // sharded, so there is no way to enforce that a given window is activated.
- // Focus tests should be interactive_ui_tests, and they should explicitly
- // activate the window. https://crbug.com/642467.
- params.window_action = chrome::NavigateParams::SHOW_WINDOW;
-
chrome::Navigate(&params);
navigation_observer.Wait();
}
« no previous file with comments | « chrome/test/BUILD.gn ('k') | chrome/test/data/webui/cr_elements/cr_action_menu_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698