Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2638383008:
Temporarily introduce ImageResourceInfo::setIsPlaceholder() (Closed)
DescriptionTemporarily introduce ImageResourceInfo::setIsPlaceholder()
This is for https://codereview.chromium.org/2543073002, and
setIsPlaceholder() will be removed later in the refactoring.
BUG=657995, 667641, 677188
Review-Url: https://codereview.chromium.org/2638383008
Cr-Commit-Position: refs/heads/master@{#449795}
Committed: https://chromium.googlesource.com/chromium/src/+/cfa9dd423a171356f71478605f903b6410fe7861
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Patch Set 5 : Rebase #Patch Set 6 : Rebase. #Patch Set 7 : Rebase #
Dependent Patchsets: Messages
Total messages: 35 (29 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Temporarily introduce ImageResourceInfo::setIsPlaceholder() BUG= ========== to ========== Temporarily introduce ImageResourceInfo::setIsPlaceholder() BUG= ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Temporarily introduce ImageResourceInfo::setIsPlaceholder() BUG= ========== to ========== Temporarily introduce ImageResourceInfo::setIsPlaceholder() This is for https://codereview.chromium.org/2543073002, and setIsPlaceholder() will be removed later in the refactoring. BUG=657995 ==========
hiroshige@chromium.org changed reviewers: + japhet@chromium.org, yhirano@chromium.org
Description was changed from ========== Temporarily introduce ImageResourceInfo::setIsPlaceholder() This is for https://codereview.chromium.org/2543073002, and setIsPlaceholder() will be removed later in the refactoring. BUG=657995 ========== to ========== Temporarily introduce ImageResourceInfo::setIsPlaceholder() This is for https://codereview.chromium.org/2543073002, and setIsPlaceholder() will be removed later in the refactoring. BUG=657995, 667641, 677188 ==========
hiroshige@chromium.org changed reviewers: + sclittle@chromium.org
PTAL.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
lgtm
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org, yhirano@chromium.org, sclittle@chromium.org Link to the patchset: https://codereview.chromium.org/2638383008/#ps120001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1486764428916060,
"parent_rev": "11d15bc350ba529ff3c37ba761b2b51954f5afff", "commit_rev":
"cfa9dd423a171356f71478605f903b6410fe7861"}
Message was sent while issue was closed.
Description was changed from ========== Temporarily introduce ImageResourceInfo::setIsPlaceholder() This is for https://codereview.chromium.org/2543073002, and setIsPlaceholder() will be removed later in the refactoring. BUG=657995, 667641, 677188 ========== to ========== Temporarily introduce ImageResourceInfo::setIsPlaceholder() This is for https://codereview.chromium.org/2543073002, and setIsPlaceholder() will be removed later in the refactoring. BUG=657995, 667641, 677188 Review-Url: https://codereview.chromium.org/2638383008 Cr-Commit-Position: refs/heads/master@{#449795} Committed: https://chromium.googlesource.com/chromium/src/+/cfa9dd423a171356f71478605f90... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/cfa9dd423a171356f71478605f90... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
