Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2643923006: [IR7][local] Don't show a placeholder if the response contains the full image. (Closed)

Created:
3 years, 11 months ago by hiroshige
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, gavinp+loader_chromium.org, blink-reviews, kinuko+watch, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WIP, local] Don't show a placeholder if the response contains the full image. Local rebase of https://codereview.chromium.org/2543073002. BUG=

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase (2017/02/10) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -15 lines) Patch
M third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp View 1 2 3 4 5 6 2 chunks +37 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp View 1 2 3 4 5 3 chunks +172 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPParsers.h View 1 2 3 4 5 2 chunks +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/network/HTTPParsers.cpp View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2638383008 Patch 120001

Dependent Patchsets:

Issue 2650543003 Patch 200001

Messages

Total messages: 22 (22 generated)
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-21 01:17:35 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643923006/1
3 years, 11 months ago (2017-01-21 01:18:11 UTC) #2
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 11 months ago (2017-01-21 02:37:53 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643923006/20001
3 years, 11 months ago (2017-01-21 02:38:09 UTC) #4
hiroshige
Description was changed from ========== [WIP, local] Don't show a placeholder if the response contains ...
3 years, 11 months ago (2017-01-21 02:38:15 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 11 months ago (2017-01-21 04:32:00 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 11 months ago (2017-01-21 04:32:00 UTC) #7
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-24 22:44:17 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643923006/40001
3 years, 10 months ago (2017-01-24 22:44:58 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-01-24 23:34:22 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/335768) win_clang on ...
3 years, 10 months ago (2017-01-24 23:34:22 UTC) #11
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-25 01:24:39 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643923006/60001
3 years, 10 months ago (2017-01-25 01:25:30 UTC) #13
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-01-25 02:25:17 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643923006/80001
3 years, 10 months ago (2017-01-25 02:26:00 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-01-25 04:21:01 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
3 years, 10 months ago (2017-01-25 04:21:02 UTC) #17
hiroshige
Description was changed from ========== [WIP, local] Don't show a placeholder if the response contains ...
3 years, 10 months ago (2017-02-10 23:31:51 UTC) #18
hiroshige
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
3 years, 10 months ago (2017-02-10 23:38:30 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2643923006/120001
3 years, 10 months ago (2017-02-10 23:39:18 UTC) #20
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 10 months ago (2017-02-11 01:36:44 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 01:36:45 UTC) #22 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698