Convert make_names and make_event_factory to use json5 config format.

Convert make_names and make_event_factory to use json5 config format.

Subsequently converted make_media_feature_names and make_media_features
as well and these config files:
  Source/core/css/MediaFeatureNames.json5
  Source/core/css/MediaTypeNames.json5
  Source/core/editing/InputModeNames.json5
  Source/core/events/EventAliases.json5
  Source/core/events/EventTargetFactory.json5
  Source/core/events/EventTypeNames.json5
  Source/core/html/forms/InputTypeNames.json5
  Source/core/html/parser/HTMLTokenizerNames.json5
  Source/modules/EventTargetModulesFactory.json5
  Source/modules/indexeddb/IndexedDBNames.json5
  Source/platform/fonts/FontFamilyNames.json5
  Source/platform/loader/fetch/FetchInitiatorTypeNames.in
  Source/platform/network/HTTPNames.json5

Small fixes to json5_generator to support the above make_* scripts
and allow default_parameters to be specified within .py scripts.

BUG=677884
Review-Url: https://codereview.chromium.org/2638233002
Cr-Commit-Position: refs/heads/master@{#445879}
Committed: https://chromium.googlesource.com/chromium/src/+/94a7540e73efd7ba5e99436188c0d00562657b5c

[ktyliu, 2017-01-18 00:36:14]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 00:36:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-01-18 01:07:23]

sashab@chromium.org changed reviewers:
+ sashab@chromium.org

[sashab, 2017-01-18 01:07:24]

Sorry to do this, but this patch is kinda big. Can it be made any smaller, like
make_names and make_event_factory in separate patchsets? And the small
enhancement, can that be done separately too?

Since you've already done it, I'll happily review this as is (don't want to
burden you with too much extra work), but maybe for future patches split them up
a bit smaller.

[commit-bot: I haz the power, 2017-01-18 01:37:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 01:37:13]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[ktyliu, 2017-01-18 02:32:41]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 02:33:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-18 02:37:50]

On 2017/01/18 at 01:07:24, sashab wrote:
> Sorry to do this, but this patch is kinda big. Can it be made any smaller,
like make_names and make_event_factory in separate patchsets? And the small
enhancement, can that be done separately too?
> 
> Since you've already done it, I'll happily review this as is (don't want to
burden you with too much extra work), but maybe for future patches split them up
a bit smaller.

Unfortunately these files are interrelated so unless we branch scripts and/or
keep both .in and .json5 configs we'll have to change them together.
Specifically:
1. make_names.py is used by several configs, so unless we have make_names_in.py
and make_names_json5, all those configs need to change together
2. make_media_feature_names.py uses make_names so it needs to change together
3. make_media_feature_names.py and make_media_features.py both take same input
MediaFeatureNames.in so they need to change together
4. some make_names take generated .in as input (eg EventModulesInterfaces.in) so
the generator generate_event_interfaces.py needs to change together
5. make_event_factory takes the generated .in as input so make_event_factory
needs to change as well

WDYT?

[commit-bot: I haz the power, 2017-01-18 03:42:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 03:42:13]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[sashab, 2017-01-18 04:17:02]

Yup, I had a feeling that was the case. Thanks for clarifying.

No prob, it can't be avoided. Let me take a look over the patch. :)

[ktyliu, 2017-01-18 04:19:15]

Cool.

CQ try seems to show that some tests are failing, possibly with the idl
change.
If that's indeed the case and require code and/or test changes I think we
can do that one separately.

On Wed, Jan 18, 2017 at 3:17 PM, <sashab@chromium.org> wrote:

> Yup, I had a feeling that was the case. Thanks for clarifying.
>
> No prob, it can't be avoided. Let me take a look over the patch. :)
>
> https://codereview.chromium.org/2638233002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[ktyliu, 2017-01-18 04:19:16]

Cool.

CQ try seems to show that some tests are failing, possibly with the idl
change.
If that's indeed the case and require code and/or test changes I think we
can do that one separately.

On Wed, Jan 18, 2017 at 3:17 PM, <sashab@chromium.org> wrote:

> Yup, I had a feeling that was the case. Thanks for clarifying.
>
> No prob, it can't be avoided. Let me take a look over the patch. :)
>
> https://codereview.chromium.org/2638233002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[ktyliu, 2017-01-19 03:59:40]

Handling the IDL change is now in separate http://crrev.com/2633383005
Once that lands, I'll rebase and merge, and ping when ready for review.

Thanks.

[ktyliu, 2017-01-19 06:25:21]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 06:25:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-19 06:27:31]

Description was changed from

==========
Convert make_names and make_event_factory to use json5 config format.

Subsequently converted make_media_feature_names and make_media_features
as well and these config files:
  Source/core/css/MediaFeatureNames.json5
  Source/core/css/MediaTypeNames.json5
  Source/core/editing/InputModeNames.json5
  Source/core/events/EventAliases.json5
  Source/core/events/EventTargetFactory.json5
  Source/core/events/EventTypeNames.json5
  Source/core/fetch/FetchInitiatorTypeNames.json5
  Source/core/html/forms/InputTypeNames.json5
  Source/core/html/parser/HTMLTokenizerNames.json5
  Source/modules/EventTargetModulesFactory.json5
  Source/modules/indexeddb/IndexedDBNames.json5
  Source/platform/fonts/FontFamilyNames.json5
  Source/platform/network/HTTPNames.json5

Removed EventAliases for core/events/TouchEvent which causes a duplicate
by defining RuntimeEnabled in TouchEvent.idl directly.

Small enhancement in JSON5 parsing in json5_generator and added support
for default_parameters within the .py parser.

BUG=677884
==========

to

==========
Convert make_names and make_event_factory to use json5 config format.

Subsequently converted make_media_feature_names and make_media_features
as well and these config files:
  Source/core/css/MediaFeatureNames.json5
  Source/core/css/MediaTypeNames.json5
  Source/core/editing/InputModeNames.json5
  Source/core/events/EventAliases.json5
  Source/core/events/EventTargetFactory.json5
  Source/core/events/EventTypeNames.json5
  Source/core/fetch/FetchInitiatorTypeNames.json5
  Source/core/html/forms/InputTypeNames.json5
  Source/core/html/parser/HTMLTokenizerNames.json5
  Source/modules/EventTargetModulesFactory.json5
  Source/modules/indexeddb/IndexedDBNames.json5
  Source/platform/fonts/FontFamilyNames.json5
  Source/platform/network/HTTPNames.json5

Small fixes to json5_generator to support the above make_* scripts
and allow default_parameters to be specified within .py scripts.

BUG=677884
==========

[commit-bot: I haz the power, 2017-01-19 09:11:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 09:11:54]

Dry run: This issue passed the CQ dry run.

[ktyliu, 2017-01-23 01:07:44]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 01:08:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-23 01:57:08]

On 2017/01/19 at 03:59:40, ktyliu wrote:
> Handling the IDL change is now in separate http://crrev.com/2633383005
> Once that lands, I'll rebase and merge, and ping when ready for review.
> 
> Thanks.

EventAliases issue is fixed by crrev.com/2644693005 so this change should now be
ready for review.

Sasha can you PTAL? Hope you had a good trip and isn't tired out :)
Thanks

[commit-bot: I haz the power, 2017-01-23 02:48:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 02:48:45]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-01-23 05:26:41]

LGTM, I thought this would take ages to review but its actually written really
well, nice :)
Just could use some formatting on the generated .json5 files, I wish there was a
js formatter we could use...

For now maybe just use a free online one, for the future maybe we can run one as
part of git cl-format. :D

https://codereview.chromium.org/2638233002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/FontFamilyNames.json5 (right):

https://codereview.chromium.org/2638233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/FontFamilyNames.json5:2: metadata:{
Can we run a formatter over these? So they look more like:

{
  metadata: {
    namespace: ...
  },
  data: [
    ...
  ]
}

I wonder if there's a way to add the formatter to git cl format, as well.

[ktyliu, 2017-01-23 06:33:41]

ktyliu@chromium.org changed reviewers:
+ mkwst@chromium.org

[ktyliu, 2017-01-23 06:33:42]

Thanks Sasha for the quick review!
Fixed formatting of the JSON5 files.

Adding Mike suggested by git-cl owners to RSLGTM changes to Source/platform,
Source/bindings, and Source/modules

Thanks,
Kevin

https://codereview.chromium.org/2638233002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/FontFamilyNames.json5 (right):

https://codereview.chromium.org/2638233002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/FontFamilyNames.json5:2: metadata:{
On 2017/01/23 at 05:26:41, sashab wrote:
> Can we run a formatter over these? So they look more like:
> 
> {
>   metadata: {
>     namespace: ...
>   },
>   data: [
>     ...
>   ]
> }
> 
> I wonder if there's a way to add the formatter to git cl format, as well.

I couldn't find a formatter that would automatically do this completely.
Closest I found is using `js-beautify --indent-size=2 --brace-style=expand` but
that would result in:
metadata:
{
  namespace: ...,
}

Used that formatter and maually fixed the "metdata: {"

[sashab, 2017-01-23 10:22:29]

https://codereview.chromium.org/2638233002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/forms/InputTypeNames.json5 (right):

https://codereview.chromium.org/2638233002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/forms/InputTypeNames.json5:31: ]
Yess! Liking this new formatting. :)

For consistency, can we have trailing commas on these too? Since we have
trailing commas on the list items themselves. I love trailing commas. >:D

[ktyliu, 2017-01-23 21:28:32]

https://codereview.chromium.org/2638233002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/forms/InputTypeNames.json5 (right):

https://codereview.chromium.org/2638233002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/forms/InputTypeNames.json5:31: ]
On 2017/01/23 at 10:22:29, sashab wrote:
> Yess! Liking this new formatting. :)
> 
> For consistency, can we have trailing commas on these too? Since we have
trailing commas on the list items themselves. I love trailing commas. >:D

Okay. Done.

Looks like js-beautify does not add or remove this trailing comma, so just need
to add this to my in_to_json5 script

[Mike West, 2017-01-24 08:33:57]

LGTM.

[ktyliu, 2017-01-24 20:26:41]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-01-24 20:26:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2638233002/#ps100001
(title: "add ],")

[commit-bot: I haz the power, 2017-01-24 20:27:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 20:30:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 20:30:40]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ktyliu, 2017-01-24 20:50:46]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 20:51:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 21:30:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 21:30:01]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[ktyliu, 2017-01-24 22:20:58]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 22:21:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-01-24 22:21:55]

Description was changed from

==========
Convert make_names and make_event_factory to use json5 config format.

Subsequently converted make_media_feature_names and make_media_features
as well and these config files:
  Source/core/css/MediaFeatureNames.json5
  Source/core/css/MediaTypeNames.json5
  Source/core/editing/InputModeNames.json5
  Source/core/events/EventAliases.json5
  Source/core/events/EventTargetFactory.json5
  Source/core/events/EventTypeNames.json5
  Source/core/fetch/FetchInitiatorTypeNames.json5
  Source/core/html/forms/InputTypeNames.json5
  Source/core/html/parser/HTMLTokenizerNames.json5
  Source/modules/EventTargetModulesFactory.json5
  Source/modules/indexeddb/IndexedDBNames.json5
  Source/platform/fonts/FontFamilyNames.json5
  Source/platform/network/HTTPNames.json5

Small fixes to json5_generator to support the above make_* scripts
and allow default_parameters to be specified within .py scripts.

BUG=677884
==========

to

==========
Convert make_names and make_event_factory to use json5 config format.

Subsequently converted make_media_feature_names and make_media_features
as well and these config files:
  Source/core/css/MediaFeatureNames.json5
  Source/core/css/MediaTypeNames.json5
  Source/core/editing/InputModeNames.json5
  Source/core/events/EventAliases.json5
  Source/core/events/EventTargetFactory.json5
  Source/core/events/EventTypeNames.json5
  Source/core/html/forms/InputTypeNames.json5
  Source/core/html/parser/HTMLTokenizerNames.json5
  Source/modules/EventTargetModulesFactory.json5
  Source/modules/indexeddb/IndexedDBNames.json5
  Source/platform/fonts/FontFamilyNames.json5
  Source/platform/loader/fetch/FetchInitiatorTypeNames.in
  Source/platform/network/HTTPNames.json5

Small fixes to json5_generator to support the above make_* scripts
and allow default_parameters to be specified within .py scripts.

BUG=677884
==========

[ktyliu, 2017-01-24 22:23:43]

On 2017/01/24 at 08:33:57, mkwst wrote:
> LGTM.

Thanks!

Initial commit failed due to conflict with crrev.com/2584423002 that moved
FetchInitiatorTypeNames from core/fetch/ to platform/loader/fetch/

Resolved conflict and running CQ dry run then commit on success

[commit-bot: I haz the power, 2017-01-25 00:35:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 00:35:16]

Dry run: This issue passed the CQ dry run.

[ktyliu, 2017-01-25 00:35:45]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-01-25 00:35:45]

The patchset sent to the CQ was uploaded after l-g-t-m from sashab@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2638233002/#ps140001
(title: "fix PLATFORM_EXPORT")

[commit-bot: I haz the power, 2017-01-25 00:36:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 00:44:30]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1485304545327310,
"parent_rev": "d903639cc3c5c078b62cb0e04926d8a1f10d7b73", "commit_rev":
"94a7540e73efd7ba5e99436188c0d00562657b5c"}

[commit-bot: I haz the power, 2017-01-25 00:45:04]

Description was changed from

==========
Convert make_names and make_event_factory to use json5 config format.

Subsequently converted make_media_feature_names and make_media_features
as well and these config files:
  Source/core/css/MediaFeatureNames.json5
  Source/core/css/MediaTypeNames.json5
  Source/core/editing/InputModeNames.json5
  Source/core/events/EventAliases.json5
  Source/core/events/EventTargetFactory.json5
  Source/core/events/EventTypeNames.json5
  Source/core/html/forms/InputTypeNames.json5
  Source/core/html/parser/HTMLTokenizerNames.json5
  Source/modules/EventTargetModulesFactory.json5
  Source/modules/indexeddb/IndexedDBNames.json5
  Source/platform/fonts/FontFamilyNames.json5
  Source/platform/loader/fetch/FetchInitiatorTypeNames.in
  Source/platform/network/HTTPNames.json5

Small fixes to json5_generator to support the above make_* scripts
and allow default_parameters to be specified within .py scripts.

BUG=677884
==========

to

==========
Convert make_names and make_event_factory to use json5 config format.

Subsequently converted make_media_feature_names and make_media_features
as well and these config files:
  Source/core/css/MediaFeatureNames.json5
  Source/core/css/MediaTypeNames.json5
  Source/core/editing/InputModeNames.json5
  Source/core/events/EventAliases.json5
  Source/core/events/EventTargetFactory.json5
  Source/core/events/EventTypeNames.json5
  Source/core/html/forms/InputTypeNames.json5
  Source/core/html/parser/HTMLTokenizerNames.json5
  Source/modules/EventTargetModulesFactory.json5
  Source/modules/indexeddb/IndexedDBNames.json5
  Source/platform/fonts/FontFamilyNames.json5
  Source/platform/loader/fetch/FetchInitiatorTypeNames.in
  Source/platform/network/HTTPNames.json5

Small fixes to json5_generator to support the above make_* scripts
and allow default_parameters to be specified within .py scripts.

BUG=677884

Review-Url: https://codereview.chromium.org/2638233002
Cr-Commit-Position: refs/heads/master@{#445879}
Committed:
https://chromium.googlesource.com/chromium/src/+/94a7540e73efd7ba5e99436188c0...
==========

[commit-bot: I haz the power, 2017-01-25 00:45:06]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/94a7540e73efd7ba5e99436188c0...