Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: third_party/WebKit/Source/build/scripts/make_media_features.py

Issue 2638233002: Convert make_names and make_event_factory to use json5 config format. (Closed)
Patch Set: fix PLATFORM_EXPORT Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/build/scripts/make_media_features.py
diff --git a/third_party/WebKit/Source/build/scripts/make_media_features.py b/third_party/WebKit/Source/build/scripts/make_media_features.py
index 54d96901113dd71893195d9d4389b8f107851a99..b1041248ebb329c2f3a00f2e6061f3d3c8e8e349 100755
--- a/third_party/WebKit/Source/build/scripts/make_media_features.py
+++ b/third_party/WebKit/Source/build/scripts/make_media_features.py
@@ -5,37 +5,30 @@
# found in the LICENSE file.
import media_feature_symbol
-import in_generator
+import json5_generator
import template_expander
import name_utilities
import sys
-class MakeMediaFeaturesWriter(in_generator.Writer):
- defaults = {
- 'Conditional': None, # FIXME: Add support for Conditional.
- 'RuntimeEnabled': None,
- 'ImplementedAs': None,
+class MakeMediaFeaturesWriter(json5_generator.Writer):
+ default_metadata = {
+ 'namespace': '',
+ 'export': '',
}
filters = {
'symbol': media_feature_symbol.getMediaFeatureSymbolWithSuffix(''),
'to_macro_style': name_utilities.to_macro_style,
}
- default_parameters = {
- 'namespace': '',
- 'export': '',
- }
- def __init__(self, in_file_path):
- super(MakeMediaFeaturesWriter, self).__init__(in_file_path)
+ def __init__(self, json5_file_path):
+ super(MakeMediaFeaturesWriter, self).__init__(json5_file_path)
self._outputs = {
('MediaFeatures.h'): self.generate_header,
}
self._template_context = {
- 'namespace': '',
- 'export': '',
- 'entries': self.in_file.name_dictionaries,
+ 'entries': self.json5_file.name_dictionaries,
}
@template_expander.use_jinja('MediaFeatures.h.tmpl', filters=filters)
@@ -43,4 +36,4 @@ class MakeMediaFeaturesWriter(in_generator.Writer):
return self._template_context
if __name__ == '__main__':
- in_generator.Maker(MakeMediaFeaturesWriter).main(sys.argv)
+ json5_generator.Maker(MakeMediaFeaturesWriter).main()

Powered by Google App Engine
This is Rietveld 408576698