cros: Fold HIDDetectionModel into HIDDetectionScreen.

cros: Fold HIDDetectionModel into HIDDetectionScreen.

HIDDetectionModel has only one derived type, HIDDetectionScreen.

BUG=672142
Review-Url: https://codereview.chromium.org/2638123002
Cr-Commit-Position: refs/heads/master@{#445170}
Committed: https://chromium.googlesource.com/chromium/src/+/6b07546314db5956f7f793d660bee51f8067ed14

[jdufault, 2017-01-17 19:25:00]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 19:25:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 20:47:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 20:47:37]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-01-18 20:40:48]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 20:41:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdufault, 2017-01-18 21:50:07]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-01-18 21:56:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 21:56:25]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-01-18 23:11:40]

Description was changed from

==========
cros: Fold HIDDetectionModel into HIDDetectionView.

HIDDetectionModel has only one derived type, HIDDetectionView.

BUG=672142
==========

to

==========
cros: Fold HIDDetectionModel into HIDDetectionView.

HIDDetectionModel has only one derived type, HIDDetectionView.

BUG=672142
==========

[jdufault, 2017-01-18 23:11:41]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org

[jdufault, 2017-01-18 23:12:21]

achuith@, PTAL when you get the chance.

[achuithb, 2017-01-18 23:19:46]

looks good overall

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/hid_detection_screen.cc (right):

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/hid_detection_screen.cc:152:
discovery_session_->Stop(base::Bind(&base::DoNothing),
curious: do you need the base::Bind here?

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/hid_detection_screen.h (right):

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/hid_detection_screen.h:47: typedef
device::InputServiceLinux::InputDeviceInfo InputDeviceInfo;
let's make this 'using' since you're here.

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/hid_detection_screen.h:66: // This method
is called, when view is being destroyed. Note, if model
This comment needs an update and better grammar. And perhaps a sentence on the
input argument.

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.h
(right):

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.h:56: //
Keeps whether screen should be shown right after initialization.
Update comment to English

[jdufault, 2017-01-20 01:13:50]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 01:14:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 02:16:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 02:16:15]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-01-20 18:57:21]

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/hid_detection_screen.cc (right):

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/hid_detection_screen.cc:152:
discovery_session_->Stop(base::Bind(&base::DoNothing),
On 2017/01/18 23:19:46, achuithb wrote:
> curious: do you need the base::Bind here?

Yep; base::DoNothing is just an empty function.

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/hid_detection_screen.h (right):

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/hid_detection_screen.h:47: typedef
device::InputServiceLinux::InputDeviceInfo InputDeviceInfo;
On 2017/01/18 23:19:46, achuithb wrote:
> let's make this 'using' since you're here.

Done.

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/hid_detection_screen.h:66: // This method
is called, when view is being destroyed. Note, if model
On 2017/01/18 23:19:46, achuithb wrote:
> This comment needs an update and better grammar. And perhaps a sentence on the
> input argument.

Done.

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.h
(right):

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.h:56: //
Keeps whether screen should be shown right after initialization.
On 2017/01/18 23:19:46, achuithb wrote:
> Update comment to English

Done.

[jdufault, 2017-01-20 18:57:49]

Description was changed from

==========
cros: Fold HIDDetectionModel into HIDDetectionView.

HIDDetectionModel has only one derived type, HIDDetectionView.

BUG=672142
==========

to

==========
cros: Fold HIDDetectionModel into HIDDetectionScreen.

HIDDetectionModel has only one derived type, HIDDetectionScreen.

BUG=672142
==========

[achuithb, 2017-01-20 19:18:38]

lgtm

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/hid_detection_screen.cc (right):

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/hid_detection_screen.cc:152:
discovery_session_->Stop(base::Bind(&base::DoNothing),
On 2017/01/20 18:57:21, jdufault wrote:
> On 2017/01/18 23:19:46, achuithb wrote:
> > curious: do you need the base::Bind here?
> 
> Yep; base::DoNothing is just an empty function.

I meant, just passing in the function pointer doesn't work, right?

https://codereview.chromium.org/2638123002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/hid_detection_screen.h (right):

https://codereview.chromium.org/2638123002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/hid_detection_screen.h:65: // Checks if
this screen should be display. |on_check_done| should be invoked
displayed

[jdufault, 2017-01-20 19:25:13]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2017-01-20 19:25:13]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2638123002/#ps60001
(title: "Nit")

[jdufault, 2017-01-20 19:25:38]

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/hid_detection_screen.cc (right):

https://codereview.chromium.org/2638123002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/hid_detection_screen.cc:152:
discovery_session_->Stop(base::Bind(&base::DoNothing),
On 2017/01/20 19:18:38, achuithb wrote:
> On 2017/01/20 18:57:21, jdufault wrote:
> > On 2017/01/18 23:19:46, achuithb wrote:
> > > curious: do you need the base::Bind here?
> > 
> > Yep; base::DoNothing is just an empty function.
> 
> I meant, just passing in the function pointer doesn't work, right?

Right :(

https://codereview.chromium.org/2638123002/diff/40001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/screens/hid_detection_screen.h (right):

https://codereview.chromium.org/2638123002/diff/40001/chrome/browser/chromeos...
chrome/browser/chromeos/login/screens/hid_detection_screen.h:65: // Checks if
this screen should be display. |on_check_done| should be invoked
On 2017/01/20 19:18:38, achuithb wrote:
> displayed

Done.

[commit-bot: I haz the power, 2017-01-20 19:25:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 21:27:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484940313457820,
"parent_rev": "b43ccf2f38c946763398101d18775e1f5534bea7", "commit_rev":
"6b07546314db5956f7f793d660bee51f8067ed14"}

[commit-bot: I haz the power, 2017-01-20 21:28:21]

Description was changed from

==========
cros: Fold HIDDetectionModel into HIDDetectionScreen.

HIDDetectionModel has only one derived type, HIDDetectionScreen.

BUG=672142
==========

to

==========
cros: Fold HIDDetectionModel into HIDDetectionScreen.

HIDDetectionModel has only one derived type, HIDDetectionScreen.

BUG=672142

Review-Url: https://codereview.chromium.org/2638123002
Cr-Commit-Position: refs/heads/master@{#445170}
Committed:
https://chromium.googlesource.com/chromium/src/+/6b07546314db5956f7f793d660be...
==========

[commit-bot: I haz the power, 2017-01-20 21:28:23]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6b07546314db5956f7f793d660be...