cros: Fold NetworkErrorModel into NetworkErrorView.

cros: Fold NetworkErrorModel into NetworkErrorView.

NetworkErrorModel had one derived type, NetworkErrorView.

BUG=672142
Review-Url: https://codereview.chromium.org/2642823011
Cr-Commit-Position: refs/heads/master@{#446153}
Committed: https://chromium.googlesource.com/chromium/src/+/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba

[jdufault, 2017-01-20 20:25:15]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 20:25:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 21:28:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 21:28:32]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-01-20 21:47:22]

Description was changed from

==========
cros: Fold NetworkErrorModel into NetworkErrorView.

NetworkErrorModel had one derived type, NetworkErrorView.

BUG=672142
==========

to

==========
cros: Fold NetworkErrorModel into NetworkErrorView.

NetworkErrorModel had one derived type, NetworkErrorView.

BUG=672142
==========

[jdufault, 2017-01-20 21:47:22]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org

[jdufault, 2017-01-20 21:47:31]

achuith@, PTAL. Thanks!

[achuithb, 2017-01-20 23:06:55]

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/error_screen.cc (right):

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/error_screen.cc:233: }
Do we need this method? Shouldn't the base class method get called?

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/error_screen.h (left):

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/error_screen.h:71: private:
Looks like you dropped this.

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/error_screen.h (right):

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/error_screen.h:52: virtual void
FixCaptivePortal();
Why is this virtual?

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/error_screen.h:70: virtual void
SetUIState(NetworkError::UIState ui_state);
why is this virtual?

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/error_screen.h:74: virtual void
SetErrorState(NetworkError::ErrorState error_state,
why is this virtual?

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/error_screen_handler.h (right):

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/error_screen_handler.h:24: //
NetworkErrorView implementation:
Also make this private?

[jdufault, 2017-01-20 23:37:00]

The CQ bit was checked by jdufault@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 23:37:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 00:57:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 00:57:18]

Dry run: This issue passed the CQ dry run.

[jdufault, 2017-01-25 00:51:34]

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/error_screen.cc (right):

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/error_screen.cc:233: }
On 2017/01/20 23:06:55, achuithb wrote:
> Do we need this method? Shouldn't the base class method get called?

Done.

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/error_screen.h (left):

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/error_screen.h:71: private:
On 2017/01/20 23:06:55, achuithb wrote:
> Looks like you dropped this. 

Done.

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/screens/error_screen.h (right):

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/error_screen.h:52: virtual void
FixCaptivePortal();
On 2017/01/20 23:06:55, achuithb wrote:
> Why is this virtual?

It is overridden in a mock.

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/error_screen.h:70: virtual void
SetUIState(NetworkError::UIState ui_state);
On 2017/01/20 23:06:55, achuithb wrote:
> why is this virtual?

It is overridden in a mock.

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/screens/error_screen.h:74: virtual void
SetErrorState(NetworkError::ErrorState error_state,
On 2017/01/20 23:06:55, achuithb wrote:
> why is this virtual?

It is overridden in a mock.

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/error_screen_handler.h (right):

https://codereview.chromium.org/2642823011/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/error_screen_handler.h:24: //
NetworkErrorView implementation:
On 2017/01/20 23:06:55, achuithb wrote:
> Also make this private?

Done.

[achuithb, 2017-01-25 00:55:11]

lgtm

[jdufault, 2017-01-25 20:24:44]

The CQ bit was checked by jdufault@chromium.org

[commit-bot: I haz the power, 2017-01-25 20:25:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 23:05:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485375884192410,
"parent_rev": "4165f8b808fa119cc593dafb257de78bc266d02c", "commit_rev":
"d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba"}

[commit-bot: I haz the power, 2017-01-25 23:05:42]

Description was changed from

==========
cros: Fold NetworkErrorModel into NetworkErrorView.

NetworkErrorModel had one derived type, NetworkErrorView.

BUG=672142
==========

to

==========
cros: Fold NetworkErrorModel into NetworkErrorView.

NetworkErrorModel had one derived type, NetworkErrorView.

BUG=672142

Review-Url: https://codereview.chromium.org/2642823011
Cr-Commit-Position: refs/heads/master@{#446153}
Committed:
https://chromium.googlesource.com/chromium/src/+/d5d12651d5fd3040b3ce1357ca0f...
==========

[commit-bot: I haz the power, 2017-01-25 23:05:43]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d5d12651d5fd3040b3ce1357ca0f...