Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2638073002: [async-await] Move PromiseCreate and PromiseRelease to TF (Closed)

Created:
3 years, 11 months ago by jgruber
Modified:
3 years, 11 months ago
Reviewers:
Dan Ehrenberg, Yang, gsathya
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[async-await] Move PromiseCreate and PromiseRelease to TF BUG=v8:5639 Review-Url: https://codereview.chromium.org/2638073002 Cr-Commit-Position: refs/heads/master@{#42508} Committed: https://chromium.googlesource.com/v8/v8/+/d37c407a81763bf41f82db915697a65fcf20d5ca

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Move to builtins-async-function.cc and address comment #

Patch Set 4 : Move to builtins-async-function.cc and address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -23 lines) Patch
M BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M src/builtins/builtins.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A src/builtins/builtins-async-function.cc View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
M src/js/async-await.js View 1 chunk +0 lines, -23 lines 0 comments Download
M src/v8.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 30 (22 generated)
jgruber
Will fix the patch errors tomorrow.
3 years, 11 months ago (2017-01-17 16:23:42 UTC) #6
jgruber
And done, PTAL.
3 years, 11 months ago (2017-01-18 13:14:17 UTC) #9
gsathya
lgtm https://codereview.chromium.org/2638073002/diff/20001/src/builtins/builtins-async-await.cc File src/builtins/builtins-async-await.cc (right): https://codereview.chromium.org/2638073002/diff/20001/src/builtins/builtins-async-await.cc#newcode28 src/builtins/builtins-async-await.cc:28: Node* const promise = AllocateAndInitJSPromise(context, parent); You don't ...
3 years, 11 months ago (2017-01-18 18:58:42 UTC) #12
jgruber
+yang for src/js, PTAL I renamed builtins-async-await.cc to builtins-async-function.cc since that seems to be the ...
3 years, 11 months ago (2017-01-19 08:58:11 UTC) #19
jgruber
3 years, 11 months ago (2017-01-19 12:19:40 UTC) #23
Yang
lgtm
3 years, 11 months ago (2017-01-19 15:12:33 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638073002/60001
3 years, 11 months ago (2017-01-19 15:13:42 UTC) #27
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 15:15:43 UTC) #30
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/d37c407a81763bf41f82db915697a65fcf2...

Powered by Google App Engine
This is Rietveld 408576698