[async-await] Move remaining async-await code to TF

[async-await] Move remaining async-await code to TF

This moves AsyncFunctionAwait{Caught,Uncaught} to CSA, and removes
async-await.js.

BUG=v8:5639
Review-Url: https://codereview.chromium.org/2643023002
Cr-Commit-Position: refs/heads/master@{#42579}
Committed: https://chromium.googlesource.com/v8/v8/+/87851fda78e45bd95833c7e50b0befaf2445f911

[jgruber, 2017-01-19 10:46:35]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 10:46:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 10:48:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 10:48:14]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/19511)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/19579)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/19481)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/32821)
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/21130)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/21214)

[jgruber, 2017-01-19 12:30:20]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 12:30:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 12:32:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 12:32:02]

Dry run: Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[jgruber, 2017-01-19 16:05:28]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 16:05:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-01-19 16:11:59]

jgruber@chromium.org changed reviewers:
+ gsathya@chromium.org

[jgruber, 2017-01-19 16:12:00]

https://codereview.chromium.org/2643023002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

https://codereview.chromium.org/2643023002/diff/1/src/bootstrapper.cc#newcode...
src/bootstrapper.cc:3353: }
Sorry for the messy diff. I moved the AsyncFunction section out of the Script
setup section, removed setup of AsyncFunction{Next,Throw}, and added setup for
the new builtins.

https://codereview.chromium.org/2643023002/diff/1/src/builtins/builtins-async...
File src/builtins/builtins-async-function.cc (right):

https://codereview.chromium.org/2643023002/diff/1/src/builtins/builtins-async...
src/builtins/builtins-async-function.cc:67: CallStub(callable, context,
sent_value, generator, SmiConstant(resume_mode));
GeneratorPrototype{Next,Return} basically boils down to this call for the
async-await case.

https://codereview.chromium.org/2643023002/diff/1/src/builtins/builtins-async...
src/builtins/builtins-async-function.cc:121: // TODO(jgruber): Use a faster
specialized version of
I think caitp has already done some work on this. Holding off until her changes
land.

https://codereview.chromium.org/2643023002/diff/1/test/mjsunit/es8/async-awai...
File test/mjsunit/es8/async-await-no-constructor.js (right):

https://codereview.chromium.org/2643023002/diff/1/test/mjsunit/es8/async-awai...
test/mjsunit/es8/async-await-no-constructor.js:27: assertEquals(2, count);
This changed because the original (non-spec compliant) optimization [0] was not
ported. I looked at the performance impact and it seems to be minor (1-4% on the
AsyncAwait microbenchmark). We can bring it back later if appropriate.

[0]
https://cs.chromium.org/chromium/src/v8/src/js/async-await.js?q=PromiseCastRe...

[commit-bot: I haz the power, 2017-01-19 16:25:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 16:25:27]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[gsathya, 2017-01-20 06:47:34]

lgtm

[jgruber, 2017-01-20 10:59:38]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 10:59:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 11:19:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 11:19:29]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[jgruber, 2017-01-20 12:18:36]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 12:18:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-01-20 12:31:04]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 12:31:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 12:54:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 12:54:49]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/21309)
  v8_win_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[jgruber, 2017-01-20 13:28:03]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 13:28:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-01-20 13:32:22]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 13:32:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-01-20 14:00:26]

jgruber@chromium.org changed reviewers:
+ caitp@igalia.com

[jgruber, 2017-01-20 14:00:27]

The latest patchset removes unused functions and contains a couple of fixes in
AsyncBuiltinsAssembler::Await.

caitp, it'd be great if you could take a quick look and confirm whether the
changes match your intentions.

I'll go ahead and land this later tonight if no objections come up.

https://codereview.chromium.org/2643023002/diff/100001/src/builtins/builtins-...
File src/builtins/builtins-async.cc (right):

https://codereview.chromium.org/2643023002/diff/100001/src/builtins/builtins-...
src/builtins/builtins-async.cc:68: if (is_predicted_as_caught)
PromiseSetHandledHint(value);
Note the inverted logic and the changed flag.

[commit-bot: I haz the power, 2017-01-20 14:09:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 14:09:10]

Dry run: This issue passed the CQ dry run.

[caitp, 2017-01-20 16:47:43]

On 2017/01/20 14:00:27, jgruber wrote:
> The latest patchset removes unused functions and contains a couple of fixes in
> AsyncBuiltinsAssembler::Await.
> 
> caitp, it'd be great if you could take a quick look and confirm whether the
> changes match your intentions.
> 
> I'll go ahead and land this later tonight if no objections come up.
> 
>
https://codereview.chromium.org/2643023002/diff/100001/src/builtins/builtins-...
> File src/builtins/builtins-async.cc (right):
> 
>
https://codereview.chromium.org/2643023002/diff/100001/src/builtins/builtins-...
> src/builtins/builtins-async.cc:68: if (is_predicted_as_caught)
> PromiseSetHandledHint(value);
> Note the inverted logic and the changed flag.

Fixes in builtins-async lgtm, nice work

[jgruber, 2017-01-20 17:16:21]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-01-20 17:16:22]

The patchset sent to the CQ was uploaded after l-g-t-m from gsathya@chromium.org
Link to the patchset: https://codereview.chromium.org/2643023002/#ps120001
(title: "Typo")

[commit-bot: I haz the power, 2017-01-20 17:16:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-01-20 17:19:21]

jgruber@chromium.org changed reviewers:
+ adamk@chromium.org

[jgruber, 2017-01-20 17:19:22]

+adamk for src/js

[commit-bot: I haz the power, 2017-01-20 17:19:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 17:19:59]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/33006)

[adamk, 2017-01-20 19:07:05]

lgtm for js/, but one question

https://codereview.chromium.org/2643023002/diff/120001/test/mjsunit/es8/async...
File test/mjsunit/es8/async-await-no-constructor.js (right):

https://codereview.chromium.org/2643023002/diff/120001/test/mjsunit/es8/async...
test/mjsunit/es8/async-await-no-constructor.js:27: assertEquals(2, count);
Why did this change?

[gsathya, 2017-01-20 19:12:37]

On 2017/01/20 19:07:05, adamk wrote:
> lgtm for js/, but one question
> 
>
https://codereview.chromium.org/2643023002/diff/120001/test/mjsunit/es8/async...
> File test/mjsunit/es8/async-await-no-constructor.js (right):
> 
>
https://codereview.chromium.org/2643023002/diff/120001/test/mjsunit/es8/async...
> test/mjsunit/es8/async-await-no-constructor.js:27: assertEquals(2, count);
> Why did this change?

https://codereview.chromium.org/2643023002/diff/1/test/mjsunit/es8/async-awai...

[jgruber, 2017-01-20 19:32:00]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2017-01-20 19:32:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 19:36:30]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484940720745250,
"parent_rev": "2ca39001c8c134fce0bfc6f9f73044ff82671156", "commit_rev":
"87851fda78e45bd95833c7e50b0befaf2445f911"}

[commit-bot: I haz the power, 2017-01-20 19:36:33]

Description was changed from

==========
[async-await] Move remaining async-await code to TF

This moves AsyncFunctionAwait{Caught,Uncaught} to CSA, and removes
async-await.js.

BUG=v8:5639
==========

to

==========
[async-await] Move remaining async-await code to TF

This moves AsyncFunctionAwait{Caught,Uncaught} to CSA, and removes
async-await.js.

BUG=v8:5639

Review-Url: https://codereview.chromium.org/2643023002
Cr-Commit-Position: refs/heads/master@{#42579}
Committed:
https://chromium.googlesource.com/v8/v8/+/87851fda78e45bd95833c7e50b0befaf244...
==========

[commit-bot: I haz the power, 2017-01-20 19:36:34]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/87851fda78e45bd95833c7e50b0befaf244...