Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2637953002: Move CaretBase::shouldRepaintCaret() to FrameCaret.cpp (Closed)

Created:
3 years, 11 months ago by yosin_UTC9
Modified:
3 years, 11 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move CaretBase::shouldRepaintCaret() to FrameCaret.cpp This patch moves |CaretBase::shouldRepaintCaret()| to "FrameCaret.cpp" because it is only used in "FrameCaret.cpp" for improving code health. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2637953002 Cr-Commit-Position: refs/heads/master@{#444017} Committed: https://chromium.googlesource.com/chromium/src/+/e44e863e19ffca8ed95c0e395641ed1679482d12

Patch Set 1 : 2017-01-17T12:43:36 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M third_party/WebKit/Source/core/editing/CaretBase.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.cpp View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yosin_UTC9
PTAL
3 years, 11 months ago (2017-01-17 06:28:33 UTC) #7
Xiaocheng
lgtm
3 years, 11 months ago (2017-01-17 07:42:17 UTC) #8
yoichio
lgtm
3 years, 11 months ago (2017-01-17 08:50:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637953002/1
3 years, 11 months ago (2017-01-17 09:53:59 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 09:59:31 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e44e863e19ffca8ed95c0e395641...

Powered by Google App Engine
This is Rietveld 408576698