third_party/WebKit/Source/core/editing/CaretBase.h - Issue 2637953002: Move CaretBase::shouldRepaintCaret() to FrameCaret.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/CaretBase.h

Issue 2637953002: Move CaretBase::shouldRepaintCaret() to FrameCaret.cpp (Closed)

Patch Set: 2017-01-17T12:43:36 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/CaretBase.h

diff --git a/third_party/WebKit/Source/core/editing/CaretBase.h b/third_party/WebKit/Source/core/editing/CaretBase.h

index 993371d9d5d49833141b130da7fca394600a4a4c..3984329e65e663f969e420444682cd56dce4de7a 100644

--- a/third_party/WebKit/Source/core/editing/CaretBase.h

+++ b/third_party/WebKit/Source/core/editing/CaretBase.h

@@ -52,10 +52,6 @@ class CaretBase final : public DisplayItemClient {

static LayoutRect computeCaretRect(const PositionWithAffinity& caretPosition);

static IntRect absoluteBoundsForLocalRect(Node*, const LayoutRect&);

- // TODO(yosin): We should move |shouldRepaintCaret()| to "FrameCaret.cpp" as

- // static file local function.

- static bool shouldRepaintCaret(Node&);

void paintCaret(Node*,

GraphicsContext&,

const LayoutRect& caretLocalRect,

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/CaretBase.cpp » ('j') | no next file with comments »