Video capture Android: make ImageReader member to allow surviving GC cycles

Video capture Android: make ImageReader member to allow surviving GC cycles

As explained in the bug, capturing video with e.g. [1] and
rotating some models screen (e.g. my Pixel), ends up borking
VideoCaptureCamera2.java; this CL has a tentative fix based
on the observation that on every rotation the art GC kicks in,
by holding on to the ImageReader instance.

This was also one of the points touched in the alleged
culprit CL [2].

BUG=660738
[1] https://simpl.info/getusermedia
[2] https://codereview.chromium.org/1957733003

Review-Url: https://codereview.chromium.org/2637853004
Cr-Commit-Position: refs/heads/master@{#444479}
Committed: https://chromium.googlesource.com/chromium/src/+/0e3b718d3342338cb1ba21f4e3ba8c508ca807ae

[mcasas, 2017-01-18 00:16:12]

Description was changed from

==========
Video capture Android: make ImageReader member to allow surviving GC cycles


BUG=660738
==========

to

==========
Video capture Android: make ImageReader member to allow surviving GC cycles

As explained in the bug, capturing video with e.g. [1] and
rotating some models screen (e.g. my Pixel), ends up borking
VideoCaptureCamera2.java; this CL has a tentative fix based
on the observation that on every rotation the art GC kicks in,
by holding on to the ImageReader instance.

BUG=660738
[1] https://simpl.info/getusermedia
==========

[mcasas, 2017-01-18 00:16:55]

Description was changed from

==========
Video capture Android: make ImageReader member to allow surviving GC cycles

As explained in the bug, capturing video with e.g. [1] and
rotating some models screen (e.g. my Pixel), ends up borking
VideoCaptureCamera2.java; this CL has a tentative fix based
on the observation that on every rotation the art GC kicks in,
by holding on to the ImageReader instance.

BUG=660738
[1] https://simpl.info/getusermedia
==========

to

==========
Video capture Android: make ImageReader member to allow surviving GC cycles

As explained in the bug, capturing video with e.g. [1] and
rotating some models screen (e.g. my Pixel), ends up borking
VideoCaptureCamera2.java; this CL has a tentative fix based
on the observation that on every rotation the art GC kicks in,
by holding on to the ImageReader instance.

This was also one of the points touched in the alleged
culprit CL [2].

BUG=660738

[1] https://simpl.info/getusermedia
[2] https://codereview.chromium.org/1957733003
==========

[mcasas, 2017-01-18 01:50:01]

mcasas@chromium.org changed reviewers:
+ niklase@chromium.or

[mcasas, 2017-01-18 01:50:02]

niklase@ ptal

[mcasas, 2017-01-18 17:57:02]

mcasas@chromium.org changed reviewers:
+ emircan@chromium.org
- niklase@chromium.or

[mcasas, 2017-01-18 17:57:02]

emircan@ PTAL

[emircan, 2017-01-18 18:42:00]

lgtm

[mcasas, 2017-01-18 18:45:59]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-01-18 18:46:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 21:12:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484765159800530, "parent_rev":
"09f2dd1f7eed9ee0bf7584f93871a117bcdf67c6", "commit_rev":
"0e3b718d3342338cb1ba21f4e3ba8c508ca807ae"}

[commit-bot: I haz the power, 2017-01-18 21:12:58]

Description was changed from

==========
Video capture Android: make ImageReader member to allow surviving GC cycles

As explained in the bug, capturing video with e.g. [1] and
rotating some models screen (e.g. my Pixel), ends up borking
VideoCaptureCamera2.java; this CL has a tentative fix based
on the observation that on every rotation the art GC kicks in,
by holding on to the ImageReader instance.

This was also one of the points touched in the alleged
culprit CL [2].

BUG=660738

[1] https://simpl.info/getusermedia
[2] https://codereview.chromium.org/1957733003
==========

to

==========
Video capture Android: make ImageReader member to allow surviving GC cycles

As explained in the bug, capturing video with e.g. [1] and
rotating some models screen (e.g. my Pixel), ends up borking
VideoCaptureCamera2.java; this CL has a tentative fix based
on the observation that on every rotation the art GC kicks in,
by holding on to the ImageReader instance.

This was also one of the points touched in the alleged
culprit CL [2].

BUG=660738

[1] https://simpl.info/getusermedia
[2] https://codereview.chromium.org/1957733003

Review-Url: https://codereview.chromium.org/2637853004
Cr-Commit-Position: refs/heads/master@{#444479}
Committed:
https://chromium.googlesource.com/chromium/src/+/0e3b718d3342338cb1ba21f4e3ba...
==========

[commit-bot: I haz the power, 2017-01-18 21:13:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0e3b718d3342338cb1ba21f4e3ba...