Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1957733003:
VideoCaptureCamera2.java, VideoCaptureCamera.java: minor cleanup (Closed)
|
Created:
4 years, 7 months ago by mcasas Modified:
4 years, 7 months ago Reviewers:
qinmin CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionVideoCaptureCamera2.java, VideoCaptureCamera.java: minor cleanup
This CL is some small groundwork in preparation for
http://crrev.com/1947933003 review.
In particular:
1. s/cr.media/cr_media/ which is causing a presubmit
warning
" Dot in log tags cause them to be elided in crash reports. "
(https://codereview.chromium.org/1389633002)
2. s/createCaptureObjects()/createPreviewObjects()/ and
other small renames in preparation for photo taking, which
is another type of capture.
3. Removed two members: |mCaptureSession| and |mImageReader|
and instead the objects are allocated on the spot.
(Picture taking basically needs to scrap the session and
its associated ImageReader after taking the picture and to
resume Preview, so holding on to these folks is not needed).
4. Folded triggerCaptureSession() into its caller (I think
is clearer like this, is a small method and I had to jump
all the time back and forth to and from it).
Except for 3. above, no new code added.
BUG=518807
Committed: https://crrev.com/37c6a9d65873e5e4d807b01992c9195df68ddaab
Cr-Commit-Position: refs/heads/master@{#392397}
Patch Set 1 #
Total comments: 6
Patch Set 2 : qinmin@ comments #
Messages
Total messages: 15 (9 generated)
Description was changed from
==========
VideoCaptureCamera{,2}.java: minor cleanup
This CL is some small groundwork in preparation for
http://crrev.com/1947933003 review
In particular:
BUG=518807
==========
to
==========
VideoCaptureCamera{,2}.java: minor cleanup
This CL is some small groundwork in preparation for
http://crrev.com/1947933003 review
In particular:
1. s/cr.media/cr_media/ which is causing a presubmit
warning
" Dot in log tags cause them to be elided in crash reports. "
(https://codereview.chromium.org/1389633002)
2. s/createCaptureObjects()/createPreviewObjects()/ and
other small renamings in preparation for photo taking, which
is another type of capture.
3. Removed two members: |mCaptureSession| and |mImageReader|
and instead the objects are allocated on the spot.
4. Folded triggerCaptureSession() into its caller (I think
is clearer like this, is a small method and I had to jump
all the time back and forth to and from it).
Except for 3. above, no new code added.
BUG=518807
==========
Description was changed from
==========
VideoCaptureCamera{,2}.java: minor cleanup
This CL is some small groundwork in preparation for
http://crrev.com/1947933003 review
In particular:
1. s/cr.media/cr_media/ which is causing a presubmit
warning
" Dot in log tags cause them to be elided in crash reports. "
(https://codereview.chromium.org/1389633002)
2. s/createCaptureObjects()/createPreviewObjects()/ and
other small renamings in preparation for photo taking, which
is another type of capture.
3. Removed two members: |mCaptureSession| and |mImageReader|
and instead the objects are allocated on the spot.
4. Folded triggerCaptureSession() into its caller (I think
is clearer like this, is a small method and I had to jump
all the time back and forth to and from it).
Except for 3. above, no new code added.
BUG=518807
==========
to
==========
VideoCaptureCamera2.java, VideoCaptureCamera.java: minor cleanup
This CL is some small groundwork in preparation for
http://crrev.com/1947933003 review.
In particular:
1. s/cr.media/cr_media/ which is causing a presubmit
warning
" Dot in log tags cause them to be elided in crash reports. "
(https://codereview.chromium.org/1389633002)
2. s/createCaptureObjects()/createPreviewObjects()/ and
other small renames in preparation for photo taking, which
is another type of capture.
3. Removed two members: |mCaptureSession| and |mImageReader|
and instead the objects are allocated on the spot.
4. Folded triggerCaptureSession() into its caller (I think
is clearer like this, is a small method and I had to jump
all the time back and forth to and from it).
Except for 3. above, no new code added.
BUG=518807
==========
Description was changed from ========== VideoCaptureCamera2.java, VideoCaptureCamera.java: minor cleanup This CL is some small groundwork in preparation for http://crrev.com/1947933003 review. In particular: 1. s/cr.media/cr_media/ which is causing a presubmit warning " Dot in log tags cause them to be elided in crash reports. " (https://codereview.chromium.org/1389633002) 2. s/createCaptureObjects()/createPreviewObjects()/ and other small renames in preparation for photo taking, which is another type of capture. 3. Removed two members: |mCaptureSession| and |mImageReader| and instead the objects are allocated on the spot. 4. Folded triggerCaptureSession() into its caller (I think is clearer like this, is a small method and I had to jump all the time back and forth to and from it). Except for 3. above, no new code added. BUG=518807 ========== to ========== VideoCaptureCamera2.java, VideoCaptureCamera.java: minor cleanup This CL is some small groundwork in preparation for http://crrev.com/1947933003 review. In particular: 1. s/cr.media/cr_media/ which is causing a presubmit warning " Dot in log tags cause them to be elided in crash reports. " (https://codereview.chromium.org/1389633002) 2. s/createCaptureObjects()/createPreviewObjects()/ and other small renames in preparation for photo taking, which is another type of capture. 3. Removed two members: |mCaptureSession| and |mImageReader| and instead the objects are allocated on the spot. (Picture taking basically needs to scrap the session and its associated ImageReader after taking the picture and to resume Preview, so holding on to these folks is not needed). 4. Folded triggerCaptureSession() into its caller (I think is clearer like this, is a small method and I had to jump all the time back and forth to and from it). Except for 3. above, no new code added. BUG=518807 ==========
mcasas@chromium.org changed reviewers: + qinmin@chromium.org
qinmin@ PTAL
lgtm % comments https://codereview.chromium.org/1957733003/diff/20001/media/capture/video/and... File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java (left): https://codereview.chromium.org/1957733003/diff/20001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:41: private static final String TAG = "cr.media"; nit: cr_ prefix is no longer required, and better making names more related to the class. VideoCapture is much better than media https://codereview.chromium.org/1957733003/diff/20001/media/capture/video/and... File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java (right): https://codereview.chromium.org/1957733003/diff/20001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:90: Log.e(TAG, "setRepeatingRequest: " + ex); Log.e(TAG, "xxx", ex); https://codereview.chromium.org/1957733003/diff/20001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:144: private static final String TAG = "cr_media"; ditto
Patchset #1 (id:1) has been deleted
The CQ bit was checked by mcasas@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from qinmin@chromium.org Link to the patchset: https://codereview.chromium.org/1957733003/#ps40001 (title: "qinmin@ comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957733003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957733003/40001
Message was sent while issue was closed.
Description was changed from ========== VideoCaptureCamera2.java, VideoCaptureCamera.java: minor cleanup This CL is some small groundwork in preparation for http://crrev.com/1947933003 review. In particular: 1. s/cr.media/cr_media/ which is causing a presubmit warning " Dot in log tags cause them to be elided in crash reports. " (https://codereview.chromium.org/1389633002) 2. s/createCaptureObjects()/createPreviewObjects()/ and other small renames in preparation for photo taking, which is another type of capture. 3. Removed two members: |mCaptureSession| and |mImageReader| and instead the objects are allocated on the spot. (Picture taking basically needs to scrap the session and its associated ImageReader after taking the picture and to resume Preview, so holding on to these folks is not needed). 4. Folded triggerCaptureSession() into its caller (I think is clearer like this, is a small method and I had to jump all the time back and forth to and from it). Except for 3. above, no new code added. BUG=518807 ========== to ========== VideoCaptureCamera2.java, VideoCaptureCamera.java: minor cleanup This CL is some small groundwork in preparation for http://crrev.com/1947933003 review. In particular: 1. s/cr.media/cr_media/ which is causing a presubmit warning " Dot in log tags cause them to be elided in crash reports. " (https://codereview.chromium.org/1389633002) 2. s/createCaptureObjects()/createPreviewObjects()/ and other small renames in preparation for photo taking, which is another type of capture. 3. Removed two members: |mCaptureSession| and |mImageReader| and instead the objects are allocated on the spot. (Picture taking basically needs to scrap the session and its associated ImageReader after taking the picture and to resume Preview, so holding on to these folks is not needed). 4. Folded triggerCaptureSession() into its caller (I think is clearer like this, is a small method and I had to jump all the time back and forth to and from it). Except for 3. above, no new code added. BUG=518807 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== VideoCaptureCamera2.java, VideoCaptureCamera.java: minor cleanup This CL is some small groundwork in preparation for http://crrev.com/1947933003 review. In particular: 1. s/cr.media/cr_media/ which is causing a presubmit warning " Dot in log tags cause them to be elided in crash reports. " (https://codereview.chromium.org/1389633002) 2. s/createCaptureObjects()/createPreviewObjects()/ and other small renames in preparation for photo taking, which is another type of capture. 3. Removed two members: |mCaptureSession| and |mImageReader| and instead the objects are allocated on the spot. (Picture taking basically needs to scrap the session and its associated ImageReader after taking the picture and to resume Preview, so holding on to these folks is not needed). 4. Folded triggerCaptureSession() into its caller (I think is clearer like this, is a small method and I had to jump all the time back and forth to and from it). Except for 3. above, no new code added. BUG=518807 ========== to ========== VideoCaptureCamera2.java, VideoCaptureCamera.java: minor cleanup This CL is some small groundwork in preparation for http://crrev.com/1947933003 review. In particular: 1. s/cr.media/cr_media/ which is causing a presubmit warning " Dot in log tags cause them to be elided in crash reports. " (https://codereview.chromium.org/1389633002) 2. s/createCaptureObjects()/createPreviewObjects()/ and other small renames in preparation for photo taking, which is another type of capture. 3. Removed two members: |mCaptureSession| and |mImageReader| and instead the objects are allocated on the spot. (Picture taking basically needs to scrap the session and its associated ImageReader after taking the picture and to resume Preview, so holding on to these folks is not needed). 4. Folded triggerCaptureSession() into its caller (I think is clearer like this, is a small method and I had to jump all the time back and forth to and from it). Except for 3. above, no new code added. BUG=518807 Committed: https://crrev.com/37c6a9d65873e5e4d807b01992c9195df68ddaab Cr-Commit-Position: refs/heads/master@{#392397} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/37c6a9d65873e5e4d807b01992c9195df68ddaab Cr-Commit-Position: refs/heads/master@{#392397}
Message was sent while issue was closed.
https://codereview.chromium.org/1957733003/diff/20001/media/capture/video/and... File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java (left): https://codereview.chromium.org/1957733003/diff/20001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera.java:41: private static final String TAG = "cr.media"; On 2016/05/09 18:05:49, qinmin wrote: > nit: cr_ prefix is no longer required, and better making names more related to > the class. VideoCapture is much better than media Done. https://codereview.chromium.org/1957733003/diff/20001/media/capture/video/and... File media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java (right): https://codereview.chromium.org/1957733003/diff/20001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:90: Log.e(TAG, "setRepeatingRequest: " + ex); On 2016/05/09 18:05:49, qinmin wrote: > Log.e(TAG, "xxx", ex); Done here and elsewhere. https://codereview.chromium.org/1957733003/diff/20001/media/capture/video/and... media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java:144: private static final String TAG = "cr_media"; On 2016/05/09 18:05:49, qinmin wrote: > ditto Done. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
