Enable ServiceWorkerNavigationPreload by default for Origin-Trial.

Enable ServiceWorkerNavigationPreload by default for Origin-Trial.

The CL https://codereview.chromium.org/2627023002/ introduced the mechanism for
Origin-Trial experiment of Service Worker Navigation Preload. But base::Feature
of the feature was disabled by default. So when we start the Origin-Trial
experiment, we had to enable the feature by the field trial mechanism. But it
is possible that the feature is not correctly enabled by the field trial
mechanism (Ex: in the first boot of Chrome). In order to avoid the confusion,
this CL enables the base::Feature of the feature by default.

If something goes wrong and we will want to stop the origin-trial, we can stop
the experiment by disabling this feature using the field trial mechanism.


  * Origin Trial: Have an effective token.
                               Command line
                           Default  Enable  Disabled
                 Default     *A*      A        B
    Field trial  Enabled      A       A        B
                 Disabled     B       A        B

  * Origin Trial: No token.
                               Command line
                           Default  Enable  Disabled
                 Default      C       A        C
    Field trial  Enabled      C       A        C
                 Disabled     C       A        C
                 
  - A: Navigation Preload related methods and attributes are available in JS
      and work correctly.
  - B: Navigation Preload related methods and attributes are available in
      JS. But NavigationPreloadManager's enable, disable and setHeaderValue
      methods always return a rejected promise. And FetchEvent's
      preloadResponse attribute returns a promise which always resolve with
      undefined.
  - C: Navigation Preload related methods and attributes are not available
      in JS.


BUG=649558
Review-Url: https://codereview.chromium.org/2637763002
Cr-Commit-Position: refs/heads/master@{#443851}
Committed: https://chromium.googlesource.com/chromium/src/+/9ad964459156c4bd27fa68a0bec4155409ec492d

[horo, 2017-01-16 04:16:10]

The CQ bit was checked by horo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 04:16:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[horo, 2017-01-16 04:24:40]

Description was changed from

==========
Enable ServiceWorkerNavigationPreload by default for Origin-Trial.

BUG=649558
==========

to

==========
Enable ServiceWorkerNavigationPreload by default for Origin-Trial.

The CL https://codereview.chromium.org/2627023002/ introduced the mechanism for
Origin-Trial experiment of Service Worker Navigation Preload. But base::Feature
of the feature was disabled by default. So when we start the Origin-Trial
experiment, we have to enable the feature by the field trial mechanism. But it
is possible that the feature is not correctly enabled by the field trial
mechanism (Ex: in the first boot of Chrome). In order to avoid the confusion,
this CL enables the base::Feature of the feature by default.

BUG=649558
==========

[horo, 2017-01-16 04:27:53]

Description was changed from

==========
Enable ServiceWorkerNavigationPreload by default for Origin-Trial.

The CL https://codereview.chromium.org/2627023002/ introduced the mechanism for
Origin-Trial experiment of Service Worker Navigation Preload. But base::Feature
of the feature was disabled by default. So when we start the Origin-Trial
experiment, we have to enable the feature by the field trial mechanism. But it
is possible that the feature is not correctly enabled by the field trial
mechanism (Ex: in the first boot of Chrome). In order to avoid the confusion,
this CL enables the base::Feature of the feature by default.

BUG=649558
==========

to

==========
The CL https://codereview.chromium.org/2627023002/ introduced the mechanism for
Origin-Trial experiment of Service Worker Navigation Preload. But base::Feature
of the feature was disabled by default. So when we start the Origin-Trial
experiment, we have to enable the feature by the field trial mechanism. But it
is possible that the feature is not correctly enabled by the field trial
mechanism (Ex: in the first boot of Chrome). In order to avoid the confusion,
this CL enables the base::Feature of the feature by default.

If something goes wrong and we will want to stop the origin-trial, we can stop
the experiment by disabling this feature using the field trial mechanism.


  * Origin Trial: Have an effective header.
                               Command line
                           Default  Enable  Disabled
                 Default     *A*      A        B
    Field trial  Enabled      A       A        B
                 Disabled     B       A        B

  * Origin Trial: No header.
                               Command line
                           Default  Enable  Disabled
                 Default      C       A        C
    Field trial  Enabled      C       A        C
                 Disabled     C       A        C
                 
  - A: Navigation Preload related methods and attributes are available in JS
      and work correctly.
  - B: Navigation Preload related methods and attributes are available in
      JS. But NavigationPreloadManager's enable, disable and setHeaderValue
      methods always return a rejected promise. And FetchEvent's
      preloadResponse attribute returns a promise which always resolve with
      undefined.
  - C: Navigation Preload related methods and attributes are not available
      in JS.


BUG=649558
==========

[horo, 2017-01-16 04:28:17]

Description was changed from

==========
The CL https://codereview.chromium.org/2627023002/ introduced the mechanism for
Origin-Trial experiment of Service Worker Navigation Preload. But base::Feature
of the feature was disabled by default. So when we start the Origin-Trial
experiment, we have to enable the feature by the field trial mechanism. But it
is possible that the feature is not correctly enabled by the field trial
mechanism (Ex: in the first boot of Chrome). In order to avoid the confusion,
this CL enables the base::Feature of the feature by default.

If something goes wrong and we will want to stop the origin-trial, we can stop
the experiment by disabling this feature using the field trial mechanism.


  * Origin Trial: Have an effective header.
                               Command line
                           Default  Enable  Disabled
                 Default     *A*      A        B
    Field trial  Enabled      A       A        B
                 Disabled     B       A        B

  * Origin Trial: No header.
                               Command line
                           Default  Enable  Disabled
                 Default      C       A        C
    Field trial  Enabled      C       A        C
                 Disabled     C       A        C
                 
  - A: Navigation Preload related methods and attributes are available in JS
      and work correctly.
  - B: Navigation Preload related methods and attributes are available in
      JS. But NavigationPreloadManager's enable, disable and setHeaderValue
      methods always return a rejected promise. And FetchEvent's
      preloadResponse attribute returns a promise which always resolve with
      undefined.
  - C: Navigation Preload related methods and attributes are not available
      in JS.


BUG=649558
==========

to

==========
The CL https://codereview.chromium.org/2627023002/ introduced the mechanism for
Origin-Trial experiment of Service Worker Navigation Preload. But base::Feature
of the feature was disabled by default. So when we start the Origin-Trial
experiment, we had to enable the feature by the field trial mechanism. But it
is possible that the feature is not correctly enabled by the field trial
mechanism (Ex: in the first boot of Chrome). In order to avoid the confusion,
this CL enables the base::Feature of the feature by default.

If something goes wrong and we will want to stop the origin-trial, we can stop
the experiment by disabling this feature using the field trial mechanism.


  * Origin Trial: Have an effective header.
                               Command line
                           Default  Enable  Disabled
                 Default     *A*      A        B
    Field trial  Enabled      A       A        B
                 Disabled     B       A        B

  * Origin Trial: No header.
                               Command line
                           Default  Enable  Disabled
                 Default      C       A        C
    Field trial  Enabled      C       A        C
                 Disabled     C       A        C
                 
  - A: Navigation Preload related methods and attributes are available in JS
      and work correctly.
  - B: Navigation Preload related methods and attributes are available in
      JS. But NavigationPreloadManager's enable, disable and setHeaderValue
      methods always return a rejected promise. And FetchEvent's
      preloadResponse attribute returns a promise which always resolve with
      undefined.
  - C: Navigation Preload related methods and attributes are not available
      in JS.


BUG=649558
==========

[horo, 2017-01-16 04:28:55]

Description was changed from

==========
The CL https://codereview.chromium.org/2627023002/ introduced the mechanism for
Origin-Trial experiment of Service Worker Navigation Preload. But base::Feature
of the feature was disabled by default. So when we start the Origin-Trial
experiment, we had to enable the feature by the field trial mechanism. But it
is possible that the feature is not correctly enabled by the field trial
mechanism (Ex: in the first boot of Chrome). In order to avoid the confusion,
this CL enables the base::Feature of the feature by default.

If something goes wrong and we will want to stop the origin-trial, we can stop
the experiment by disabling this feature using the field trial mechanism.


  * Origin Trial: Have an effective header.
                               Command line
                           Default  Enable  Disabled
                 Default     *A*      A        B
    Field trial  Enabled      A       A        B
                 Disabled     B       A        B

  * Origin Trial: No header.
                               Command line
                           Default  Enable  Disabled
                 Default      C       A        C
    Field trial  Enabled      C       A        C
                 Disabled     C       A        C
                 
  - A: Navigation Preload related methods and attributes are available in JS
      and work correctly.
  - B: Navigation Preload related methods and attributes are available in
      JS. But NavigationPreloadManager's enable, disable and setHeaderValue
      methods always return a rejected promise. And FetchEvent's
      preloadResponse attribute returns a promise which always resolve with
      undefined.
  - C: Navigation Preload related methods and attributes are not available
      in JS.


BUG=649558
==========

to

==========
Enable ServiceWorkerNavigationPreload by default for Origin-Trial.

The CL https://codereview.chromium.org/2627023002/ introduced the mechanism for
Origin-Trial experiment of Service Worker Navigation Preload. But base::Feature
of the feature was disabled by default. So when we start the Origin-Trial
experiment, we had to enable the feature by the field trial mechanism. But it
is possible that the feature is not correctly enabled by the field trial
mechanism (Ex: in the first boot of Chrome). In order to avoid the confusion,
this CL enables the base::Feature of the feature by default.

If something goes wrong and we will want to stop the origin-trial, we can stop
the experiment by disabling this feature using the field trial mechanism.


  * Origin Trial: Have an effective header.
                               Command line
                           Default  Enable  Disabled
                 Default     *A*      A        B
    Field trial  Enabled      A       A        B
                 Disabled     B       A        B

  * Origin Trial: No header.
                               Command line
                           Default  Enable  Disabled
                 Default      C       A        C
    Field trial  Enabled      C       A        C
                 Disabled     C       A        C
                 
  - A: Navigation Preload related methods and attributes are available in JS
      and work correctly.
  - B: Navigation Preload related methods and attributes are available in
      JS. But NavigationPreloadManager's enable, disable and setHeaderValue
      methods always return a rejected promise. And FetchEvent's
      preloadResponse attribute returns a promise which always resolve with
      undefined.
  - C: Navigation Preload related methods and attributes are not available
      in JS.


BUG=649558
==========

[horo, 2017-01-16 04:29:45]

Description was changed from

==========
Enable ServiceWorkerNavigationPreload by default for Origin-Trial.

The CL https://codereview.chromium.org/2627023002/ introduced the mechanism for
Origin-Trial experiment of Service Worker Navigation Preload. But base::Feature
of the feature was disabled by default. So when we start the Origin-Trial
experiment, we had to enable the feature by the field trial mechanism. But it
is possible that the feature is not correctly enabled by the field trial
mechanism (Ex: in the first boot of Chrome). In order to avoid the confusion,
this CL enables the base::Feature of the feature by default.

If something goes wrong and we will want to stop the origin-trial, we can stop
the experiment by disabling this feature using the field trial mechanism.


  * Origin Trial: Have an effective header.
                               Command line
                           Default  Enable  Disabled
                 Default     *A*      A        B
    Field trial  Enabled      A       A        B
                 Disabled     B       A        B

  * Origin Trial: No header.
                               Command line
                           Default  Enable  Disabled
                 Default      C       A        C
    Field trial  Enabled      C       A        C
                 Disabled     C       A        C
                 
  - A: Navigation Preload related methods and attributes are available in JS
      and work correctly.
  - B: Navigation Preload related methods and attributes are available in
      JS. But NavigationPreloadManager's enable, disable and setHeaderValue
      methods always return a rejected promise. And FetchEvent's
      preloadResponse attribute returns a promise which always resolve with
      undefined.
  - C: Navigation Preload related methods and attributes are not available
      in JS.


BUG=649558
==========

to

==========
Enable ServiceWorkerNavigationPreload by default for Origin-Trial.

The CL https://codereview.chromium.org/2627023002/ introduced the mechanism for
Origin-Trial experiment of Service Worker Navigation Preload. But base::Feature
of the feature was disabled by default. So when we start the Origin-Trial
experiment, we had to enable the feature by the field trial mechanism. But it
is possible that the feature is not correctly enabled by the field trial
mechanism (Ex: in the first boot of Chrome). In order to avoid the confusion,
this CL enables the base::Feature of the feature by default.

If something goes wrong and we will want to stop the origin-trial, we can stop
the experiment by disabling this feature using the field trial mechanism.


  * Origin Trial: Have an effective token.
                               Command line
                           Default  Enable  Disabled
                 Default     *A*      A        B
    Field trial  Enabled      A       A        B
                 Disabled     B       A        B

  * Origin Trial: No token.
                               Command line
                           Default  Enable  Disabled
                 Default      C       A        C
    Field trial  Enabled      C       A        C
                 Disabled     C       A        C
                 
  - A: Navigation Preload related methods and attributes are available in JS
      and work correctly.
  - B: Navigation Preload related methods and attributes are available in
      JS. But NavigationPreloadManager's enable, disable and setHeaderValue
      methods always return a rejected promise. And FetchEvent's
      preloadResponse attribute returns a promise which always resolve with
      undefined.
  - C: Navigation Preload related methods and attributes are not available
      in JS.


BUG=649558
==========

[horo, 2017-01-16 04:45:50]

horo@chromium.org changed reviewers:
+ falken@chromium.org

[horo, 2017-01-16 04:45:51]

falken@
Please review this.

[falken, 2017-01-16 04:55:53]

lgtm

[horo, 2017-01-16 04:58:13]

horo@chromium.org changed reviewers:
+ kinuko@chromium.org

[horo, 2017-01-16 04:58:13]

kinuko@
Could you please review
content/child/runtime_features.cc content/public/common/content_features.cc?

[kinuko, 2017-01-16 05:07:10]

lgtm

https://codereview.chromium.org/2637763002/diff/1/content/public/common/conte...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/2637763002/diff/1/content/public/common/conte...
content/public/common/content_features.cc:195: // runtime_features.cc and
service_worker_version.h for the details.
nit: avoid using 'we' in general, e.g. 'Enables this base::Feature by default
for Origin-Trial, but enables the corresponding blink::WebRuntimeFeatures only
when '--enable-features' command line flag is given.  See the...'

[horo, 2017-01-16 05:30:37]

Thank you.

https://codereview.chromium.org/2637763002/diff/1/content/public/common/conte...
File content/public/common/content_features.cc (right):

https://codereview.chromium.org/2637763002/diff/1/content/public/common/conte...
content/public/common/content_features.cc:195: // runtime_features.cc and
service_worker_version.h for the details.
On 2017/01/16 05:07:10, kinuko wrote:
> nit: avoid using 'we' in general, e.g. 'Enables this base::Feature by default
> for Origin-Trial, but enables the corresponding blink::WebRuntimeFeatures only
> when '--enable-features' command line flag is given.  See the...'

Done.

[horo, 2017-01-16 05:31:38]

The CQ bit was checked by horo@chromium.org

[horo, 2017-01-16 05:31:38]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org,
kinuko@chromium.org
Link to the patchset: https://codereview.chromium.org/2637763002/#ps20001
(title: "incorporated kinuko's comment")

[commit-bot: I haz the power, 2017-01-16 05:31:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 06:54:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484544698370990,
"parent_rev": "4bb402f2c33c749362a6b6d3baf6220d9ec6a759", "commit_rev":
"9ad964459156c4bd27fa68a0bec4155409ec492d"}

[commit-bot: I haz the power, 2017-01-16 06:55:49]

Description was changed from

==========
Enable ServiceWorkerNavigationPreload by default for Origin-Trial.

The CL https://codereview.chromium.org/2627023002/ introduced the mechanism for
Origin-Trial experiment of Service Worker Navigation Preload. But base::Feature
of the feature was disabled by default. So when we start the Origin-Trial
experiment, we had to enable the feature by the field trial mechanism. But it
is possible that the feature is not correctly enabled by the field trial
mechanism (Ex: in the first boot of Chrome). In order to avoid the confusion,
this CL enables the base::Feature of the feature by default.

If something goes wrong and we will want to stop the origin-trial, we can stop
the experiment by disabling this feature using the field trial mechanism.


  * Origin Trial: Have an effective token.
                               Command line
                           Default  Enable  Disabled
                 Default     *A*      A        B
    Field trial  Enabled      A       A        B
                 Disabled     B       A        B

  * Origin Trial: No token.
                               Command line
                           Default  Enable  Disabled
                 Default      C       A        C
    Field trial  Enabled      C       A        C
                 Disabled     C       A        C
                 
  - A: Navigation Preload related methods and attributes are available in JS
      and work correctly.
  - B: Navigation Preload related methods and attributes are available in
      JS. But NavigationPreloadManager's enable, disable and setHeaderValue
      methods always return a rejected promise. And FetchEvent's
      preloadResponse attribute returns a promise which always resolve with
      undefined.
  - C: Navigation Preload related methods and attributes are not available
      in JS.


BUG=649558
==========

to

==========
Enable ServiceWorkerNavigationPreload by default for Origin-Trial.

The CL https://codereview.chromium.org/2627023002/ introduced the mechanism for
Origin-Trial experiment of Service Worker Navigation Preload. But base::Feature
of the feature was disabled by default. So when we start the Origin-Trial
experiment, we had to enable the feature by the field trial mechanism. But it
is possible that the feature is not correctly enabled by the field trial
mechanism (Ex: in the first boot of Chrome). In order to avoid the confusion,
this CL enables the base::Feature of the feature by default.

If something goes wrong and we will want to stop the origin-trial, we can stop
the experiment by disabling this feature using the field trial mechanism.


  * Origin Trial: Have an effective token.
                               Command line
                           Default  Enable  Disabled
                 Default     *A*      A        B
    Field trial  Enabled      A       A        B
                 Disabled     B       A        B

  * Origin Trial: No token.
                               Command line
                           Default  Enable  Disabled
                 Default      C       A        C
    Field trial  Enabled      C       A        C
                 Disabled     C       A        C
                 
  - A: Navigation Preload related methods and attributes are available in JS
      and work correctly.
  - B: Navigation Preload related methods and attributes are available in
      JS. But NavigationPreloadManager's enable, disable and setHeaderValue
      methods always return a rejected promise. And FetchEvent's
      preloadResponse attribute returns a promise which always resolve with
      undefined.
  - C: Navigation Preload related methods and attributes are not available
      in JS.


BUG=649558

Review-Url: https://codereview.chromium.org/2637763002
Cr-Commit-Position: refs/heads/master@{#443851}
Committed:
https://chromium.googlesource.com/chromium/src/+/9ad964459156c4bd27fa68a0bec4...
==========

[commit-bot: I haz the power, 2017-01-16 06:55:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9ad964459156c4bd27fa68a0bec4...