Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: content/child/runtime_features.cc

Issue 2637763002: Enable ServiceWorkerNavigationPreload by default for Origin-Trial. (Closed)
Patch Set: incorporated kinuko's comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | content/public/common/content_features.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/runtime_features.cc
diff --git a/content/child/runtime_features.cc b/content/child/runtime_features.cc
index 96e349ff18aecb2335349ee6861fa8464f0bc3c7..eca23b3f59273b1b621eb6c0a07a3b6379b67c25 100644
--- a/content/child/runtime_features.cc
+++ b/content/child/runtime_features.cc
@@ -314,13 +314,13 @@ void SetRuntimeFeaturesDefaultsAndUpdateFromArgs(
base::FeatureList::IsEnabled(features::kWebPayments));
#endif
- // We set the RuntimeEnabledFeatures for Navigation Preload feature only when
- // it is set by "--enable-features" flag.
- // While we are experimenting this feature using Origin Trial, we enable this
- // feature using the field trial mechanism. So FeatureList::IsEnabled() always
- // returns true. But, unless the command line explicitly enabled the feature,
- // this feature should be available only when a valid origin trial token is
- // set. This check is done by the generated code of
+ // Sets the RuntimeEnabledFeatures for Navigation Preload feature only when
+ // '--enable-features' command line flag is given. While experimenting this
+ // feature using Origin-Trial, this base::Feature is enabled by default in
+ // content_features.cc. So FeatureList::IsEnabled() always returns true. But,
+ // unless the command line explicitly enabled the feature, this feature should
+ // be available only when a valid origin trial token is set. This check is
+ // done by the generated code of
// blink::OriginTrials::serviceWorkerNavigationPreloadEnabled(). See the
// comments in service_worker_version.h for the details.
if (base::FeatureList::GetInstance()->IsFeatureOverriddenFromCommandLine(
« no previous file with comments | « content/browser/service_worker/service_worker_version.h ('k') | content/public/common/content_features.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698