Issue 263763002: Disable U_ENABLE_DYLOAD in icu*gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 263763002: Disable U_ENABLE_DYLOAD in icu*gyp (Closed)

Created:
6 years, 7 months ago by jungshik at Google

Modified:
6 years, 7 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/

Visibility:
Public.

More Reviews

Description

Disable U_ENABLE_DYLOAD in icu*gyp dl_open and friends are only used by ICU plugins that we don't use. Nacl-related targets (with newlib) fail because dlfcn.h is missing. Setting U_ENABLE_DYLOAD to 0, we don't have to worry about dlfcn.h any more (it's not included) BUG=132145 TEST=After running build/gyp_chromium, build 'base_i18n_nacl' target. It should succeed without complaining about dlfcn.h. R=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267357

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	icu.gyp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	icu_nacl.gyp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

On 2014/04/30 22:19:08, Jungshik Shin wrote: > Can you review? By disabling DYLOAD, dlfcn.h is ...

6 years, 7 months ago (2014-04-30 22:23:29 UTC) #2

jungshik at Google

6 years, 7 months ago (2014-04-30 22:25:13 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r267357 (presubmit successful).

Expand Messages | Collapse Messages