Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: icu_nacl.gyp

Issue 263763002: Disable U_ENABLE_DYLOAD in icu*gyp (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « icu.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: icu_nacl.gyp
===================================================================
--- icu_nacl.gyp (revision 267150)
+++ icu_nacl.gyp (working copy)
@@ -13,6 +13,9 @@
# Tell ICU to not insert |using namespace icu;| into its headers,
# so that chrome's source explicitly has to use |icu::|.
'U_USING_ICU_NAMESPACE=0',
+ # We don't use ICU plugins and dyload is only necessary for them.
+ # NaCl-related builds also fail looking for dlfcn.h when it's enabled.
+ 'U_ENABLE_DYLOAD=0',
],
},
'defines': [
« no previous file with comments | « icu.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698