Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2637603002: [Payments] Use formatter currency code on desktop (Closed)

Created:
3 years, 11 months ago by Mathieu
Modified:
3 years, 11 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, tfarina, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, haraken, Aaron Boodman, blink-reviews, darin (slow to review), sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] Use formatter currency code on desktop Also fix the currency_system mojo definition to be normal_case. BUG=680803, 679797 TEST=existing Review-Url: https://codereview.chromium.org/2637603002 Cr-Commit-Position: refs/heads/master@{#444106} Committed: https://chromium.googlesource.com/chromium/src/+/6530e608480f9fae46b7ae5668636cce2d57814b

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyFormatter.java View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/order_summary_view_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_sheet_view_controller.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/payments/payment_details_validation.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/payments/payment_request.mojom View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 26 (17 generated)
Mathieu
sky@chromium.org: Please review changes in chrome/browser/ui rouslan@: Please review the rest
3 years, 11 months ago (2017-01-16 14:53:45 UTC) #12
please use gerrit instead
lgtm
3 years, 11 months ago (2017-01-16 17:55:41 UTC) #13
Mathieu
+tsepez for the mojom file
3 years, 11 months ago (2017-01-16 17:59:37 UTC) #15
sky
LGTM
3 years, 11 months ago (2017-01-17 17:49:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637603002/20001
3 years, 11 months ago (2017-01-17 17:51:11 UTC) #18
Mathieu
On 2017/01/17 17:51:11, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 11 months ago (2017-01-17 17:52:48 UTC) #20
Tom Sepez
lgtm
3 years, 11 months ago (2017-01-17 18:55:55 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637603002/20001
3 years, 11 months ago (2017-01-17 19:01:05 UTC) #23
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 19:22:33 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6530e608480f9fae46b7ae566863...

Powered by Google App Engine
This is Rietveld 408576698