Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2175)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyFormatter.java

Issue 2637603002: [Payments] Use formatter currency code on desktop (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/payments/order_summary_view_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyFormatter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyFormatter.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyFormatter.java
index e3b9291a344f74c9314f385b8be5d1bd70abbad4..e8694fbadb309538e97082530d2b7fa939cf3288 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyFormatter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/CurrencyFormatter.java
@@ -37,7 +37,8 @@ public class CurrencyFormatter {
assert currencyCode != null : "currencyCode should not be null";
assert userLocale != null : "userLocale should not be null";
- // Note that this technically leaks the native object.
+ // Note that this pointer could leak the native object. The called must call destroy() to
+ // ensure that the native object is destroyed.
mCurrencyFormatterAndroid = nativeInitCurrencyFormatterAndroid(
currencyCode, currencySystem == null ? "" : currencySystem, userLocale.toString());
}
« no previous file with comments | « no previous file | chrome/browser/ui/views/payments/order_summary_view_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698