Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2637533002: Revert of Temporarily skip debugger/debug/es8/async-function-debug-scopes test. (Closed)

Created:
3 years, 11 months ago by kozy
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Temporarily skip debugger/debug/es8/async-function-debug-scopes test. (patchset #1 id:1 of https://codereview.chromium.org/2636473002/ ) Reason for revert: Inspector doesn't call any JS on async event any more. https://codereview.chromium.org/2623313005/ Original issue's description: > Temporarily skip debugger/debug/es8/async-function-debug-scopes test. > > BUG=v8:5837 > NOTRY=true > > Review-Url: https://codereview.chromium.org/2636473002 > Cr-Commit-Position: refs/heads/master@{#42319} > Committed: https://chromium.googlesource.com/v8/v8/+/93aca16937b131dd735ed0b087fd4d17d0004adb TBR=machenbach@chromium.org,ishell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5837 Review-Url: https://codereview.chromium.org/2637533002 Cr-Commit-Position: refs/heads/master@{#42345} Committed: https://chromium.googlesource.com/v8/v8/+/5a1ad6bd1fe6e0b878fd723787b92428769ef5b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M test/debugger/debugger.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kozy
Created Revert of Temporarily skip debugger/debug/es8/async-function-debug-scopes test.
3 years, 11 months ago (2017-01-13 23:36:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637533002/1
3 years, 11 months ago (2017-01-13 23:37:00 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 23:37:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/5a1ad6bd1fe6e0b878fd723787b92428769...

Powered by Google App Engine
This is Rietveld 408576698