Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2636473002: Temporarily skip debugger/debug/es8/async-function-debug-scopes test. (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Temporarily skip debugger/debug/es8/async-function-debug-scopes test. BUG=v8:5837 NOTRY=true Review-Url: https://codereview.chromium.org/2636473002 Cr-Commit-Position: refs/heads/master@{#42319} Committed: https://chromium.googlesource.com/v8/v8/+/93aca16937b131dd735ed0b087fd4d17d0004adb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/debugger/debugger.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-13 11:43:00 UTC) #2
Michael Achenbach
lgtm
3 years, 11 months ago (2017-01-13 11:47:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636473002/1
3 years, 11 months ago (2017-01-13 11:47:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/93aca16937b131dd735ed0b087fd4d17d0004adb
3 years, 11 months ago (2017-01-13 11:49:26 UTC) #12
kozy
3 years, 11 months ago (2017-01-13 23:36:53 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2637533002/ by kozyatinskiy@chromium.org.

The reason for reverting is: Inspector doesn't call any JS on async event any
more.

https://codereview.chromium.org/2623313005/.

Powered by Google App Engine
This is Rietveld 408576698