Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2637503002: Tidy FXJS_V8, backfill tests. (Closed)

Created:
3 years, 11 months ago by Tom Sepez
Modified:
3 years, 11 months ago
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Tidy FXJS_V8, backfill tests. Move checks performed as part of JS_Value's object and array handling back into FXJS, to ease removal of JS_Value in the future. Remove some convenience routines in FXJS for objects, to shrink API to be covered during testing. Change some naming (number => double, string => widestring) to make it clearer when there is a C++ type involved. BUG= TBR=jochen@chromium.org Review-Url: https://codereview.chromium.org/2637503002 Committed: https://pdfium.googlesource.com/pdfium/+/e6cf01356e3336dc4f0717a391d9067693a418c1

Patch Set 1 #

Patch Set 2 : empty tests #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -151 lines) Patch
M fpdfsdk/javascript/Document.cpp View 2 chunks +18 lines, -12 lines 0 comments Download
M fpdfsdk/javascript/JS_Value.cpp View 11 chunks +13 lines, -14 lines 0 comments Download
M fpdfsdk/javascript/global.cpp View 3 chunks +27 lines, -25 lines 0 comments Download
M fxjs/fxjs_v8.h View 3 chunks +9 lines, -25 lines 0 comments Download
M fxjs/fxjs_v8.cpp View 3 chunks +16 lines, -74 lines 0 comments Download
M fxjs/fxjs_v8_embeddertest.cpp View 1 2 chunks +138 lines, -1 line 0 comments Download

Messages

Total messages: 19 (15 generated)
Tom Sepez
Dan, Jochen, PTAL.
3 years, 11 months ago (2017-01-18 21:23:43 UTC) #10
dsinclair
lgtm
3 years, 11 months ago (2017-01-18 22:08:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637503002/40001
3 years, 11 months ago (2017-01-18 22:38:02 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 22:38:22 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/e6cf01356e3336dc4f0717a391d9067693a4...

Powered by Google App Engine
This is Rietveld 408576698