Tidy FXJS_V8, backfill tests.

fxjs/fxjs_v8.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 // FXJS_V8 is a layer that makes it easier to define native objects in V8, but
 // has no knowledge of PDF-specific native objects. It could in theory be used
 // to implement other sets of native objects.
 
@@ skipping 158 matching lines @@
 
   // Called after FXJS_Define* calls made.
   void InitializeEngine();
   void ReleaseEngine();
 
   // Called after FXJS_InitializeEngine call made.
   int Execute(const CFX_WideString& script, FXJSErr* perror);
 
   v8::Local<v8::Context> NewLocalContext();
   v8::Local<v8::Context> GetPersistentContext();
+  v8::Local<v8::Object> GetThisObj();
 
   v8::Local<v8::Value> NewNull();
   v8::Local<v8::Array> NewArray();
   v8::Local<v8::Value> NewNumber(int number);
   v8::Local<v8::Value> NewNumber(double number);
   v8::Local<v8::Value> NewNumber(float number);
   v8::Local<v8::Value> NewBoolean(bool b);
-  v8::Local<v8::Value> NewString(const wchar_t* str);
+  v8::Local<v8::Value> NewString(const CFX_WideString& str);
   v8::Local<v8::Date> NewDate(double d);
   v8::Local<v8::Object> NewFxDynamicObj(int nObjDefnID, bool bStatic = false);
 
-  v8::Local<v8::Object> GetThisObj();
   int ToInt32(v8::Local<v8::Value> pValue);
   bool ToBoolean(v8::Local<v8::Value> pValue);
-  double ToNumber(v8::Local<v8::Value> pValue);
-  CFX_WideString ToString(v8::Local<v8::Value> pValue);
+  double ToDouble(v8::Local<v8::Value> pValue);
+  CFX_WideString ToWideString(v8::Local<v8::Value> pValue);
   v8::Local<v8::Object> ToObject(v8::Local<v8::Value> pValue);
   v8::Local<v8::Array> ToArray(v8::Local<v8::Value> pValue);
 
+  // Arrays.
   unsigned GetArrayLength(v8::Local<v8::Array> pArray);
   v8::Local<v8::Value> GetArrayElement(v8::Local<v8::Array> pArray,
                                        unsigned index);
   unsigned PutArrayElement(v8::Local<v8::Array> pArray,
                            unsigned index,
                            v8::Local<v8::Value> pValue);
 
+  // Objects.
   std::vector<CFX_WideString> GetObjectPropertyNames(
       v8::Local<v8::Object> pObj);
   v8::Local<v8::Value> GetObjectProperty(v8::Local<v8::Object> pObj,
                                          const CFX_WideString& PropertyName);
-
-  void PutObjectString(v8::Local<v8::Object> pObj,
-                       const CFX_WideString& wsPropertyName,
-                       const CFX_WideString& wsValue);
-  void PutObjectNumber(v8::Local<v8::Object> pObj,
-                       const CFX_WideString& PropertyName,
-                       int nValue);
-  void PutObjectNumber(v8::Local<v8::Object> pObj,
-                       const CFX_WideString& PropertyName,
-                       float fValue);
-  void PutObjectNumber(v8::Local<v8::Object> pObj,
-                       const CFX_WideString& PropertyName,
-                       double dValue);
-  void PutObjectBoolean(v8::Local<v8::Object> pObj,
-                        const CFX_WideString& PropertyName,
-                        bool bValue);
-  void PutObjectObject(v8::Local<v8::Object> pObj,
-                       const CFX_WideString& PropertyName,
-                       v8::Local<v8::Object> pPut);
-  void PutObjectNull(v8::Local<v8::Object> pObj,
-                     const CFX_WideString& PropertyName);
+  void PutObjectProperty(v8::Local<v8::Object> pObj,
+                         const CFX_WideString& PropertyName,
+                         v8::Local<v8::Value> pValue);
 
   // Native object binding.
   void SetObjectPrivate(v8::Local<v8::Object> pObj, void* p);
   void* GetObjectPrivate(v8::Local<v8::Object> pObj);
   static void FreeObjectPrivate(void* p);
   static void FreeObjectPrivate(v8::Local<v8::Object> pObj);
 
   void SetConstArray(const CFX_WideString& name, v8::Local<v8::Array> array);
   v8::Local<v8::Array> GetConstArray(const CFX_WideString& name);
 
   v8::Local<v8::String> WSToJSString(const CFX_WideString& wsPropertyName);
   void Error(const CFX_WideString& message);
 
  protected:
   CFXJS_Engine();
 
   void SetIsolate(v8::Isolate* pIsolate) { m_isolate = pIsolate; }
 
  private:
   v8::Isolate* m_isolate;
   v8::Global<v8::Context> m_V8PersistentContext;
   std::vector<v8::Global<v8::Object>*> m_StaticObjects;
   std::map<CFX_WideString, v8::Global<v8::Array>> m_ConstArrays;
 };
 
 #endif  // FXJS_FXJS_V8_H_