Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2637363002: [turbofan] Unify Smi checking for Check(Internalized)String. (Closed)

Created:
3 years, 11 months ago by Benedikt Meurer
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Unify Smi checking for Check(Internalized)String. Use the representation selector to insert appropriate Smi checks for CheckString and CheckInternalizedString when necessary. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2637363002 Cr-Commit-Position: refs/heads/master@{#42434} Committed: https://chromium.googlesource.com/v8/v8/+/ca20218ef2f35e7e1dedb2125b6b8cfbd6a1a3c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -15 lines) Patch
M src/compiler/effect-control-linearizer.cc View 2 chunks +5 lines, -13 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Benedikt Meurer
3 years, 11 months ago (2017-01-18 05:19:56 UTC) #1
Benedikt Meurer
Hey Jaro, Here's some cleanup, which might also help performance in some cases. Please take ...
3 years, 11 months ago (2017-01-18 05:23:53 UTC) #4
Jarin
lgtm
3 years, 11 months ago (2017-01-18 07:03:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637363002/1
3 years, 11 months ago (2017-01-18 07:04:46 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 07:06:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ca20218ef2f35e7e1dedb2125b6b8cfbd6a...

Powered by Google App Engine
This is Rietveld 408576698